-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ABP Framework of Platforms #3223
base: main
Are you sure you want to change the base?
Conversation
ABP Framework added to Platforms
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below is a list of changes you should make to comply with the awesome guidelines. To check your list for errors like these, you can run awesome-lint list with this command:
npx awesome-lint https://github.com/abpframework/awesome-abp
README.md:3:1
✖ 1:1 Missing file contributing.md remark-lint:awesome-contributing
✖ 1:1 Awesome list must reside in a valid git repository remark-lint:awesome-github
✖ 1:1 Missing or invalid Table of Contents remark-lint:awesome-toc
✖ 3:1 Unexpected character ! at end of heading, remove it remark-lint:no-heading-punctuation
✖ 9:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 10:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 11:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 12:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 13:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 14:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 15:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 16:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 17:3 Invalid list item link URL remark-lint:awesome-list-item
✖ 23:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 23:3 Invalid list item link remark-lint:awesome-list-item
✖ 24:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 24:3 Invalid list item link remark-lint:awesome-list-item
✖ 25:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 25:3 Invalid list item link remark-lint:awesome-list-item
✖ 25:5 https://abp.io/community/ remark-lint:double-link
✖ 26:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 26:3 Invalid list item link remark-lint:awesome-list-item
✖ 30:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 30:4 Invalid list item link remark-lint:awesome-list-item
✖ 31:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 31:4 Invalid list item link remark-lint:awesome-list-item
✖ 32:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 32:4 Invalid list item link remark-lint:awesome-list-item
✖ 32:6 Text "stackoverflow" should be written as "Stack Overflow" remark-lint:awesome-spell-check
✖ 33:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 33:4 Invalid list item link remark-lint:awesome-list-item
✖ 33:6 Text "github" should be written as "GitHub" remark-lint:awesome-spell-check
✖ 37:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 37:56 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 43:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 43:84 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 44:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 44:59 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 45:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 45:89 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 55:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 56:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 57:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 65:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 65:85 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 66:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 66:62 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 67:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 67:46 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 68:3 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 68:84 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 69:3 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 69:65 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 81:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 81:56 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 82:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 82:68 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 83:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 83:72 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 84:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 84:51 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 84:118 https://abp.io/docs/latest/Modules/Cms-Kit/Index remark-lint:double-link
✖ 85:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 85:3 https://abp.io/docs/latest/Modules/Cms-Kit/Index remark-lint:double-link
✖ 85:62 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 86:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 86:50 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 87:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 87:78 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 88:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 88:58 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 89:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 89:70 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 90:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 90:62 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 91:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 91:84 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 92:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 92:78 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 93:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 93:76 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 99:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 99:53 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 100:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 100:63 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 101:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 101:43 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 102:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 102:52 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 103:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 103:64 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 104:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 104:45 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 105:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 105:43 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 106:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 106:55 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 107:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 107:70 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 108:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 108:72 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 109:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 109:49 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 110:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 110:43 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 111:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 111:81 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 112:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 112:59 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 116:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 116:44 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 117:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 117:36 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 118:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 118:38 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 119:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 119:54 List item link and description must be separated with a dash remark-lint:awesome-list-item
✖ 123:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 127:9 https://abp.io/community/ remark-lint:double-link
✖ 131:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 137:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
✖ 138:1 Unexpected unordered list marker *, expected - remark-lint:unordered-list-marker-style
122 errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your list is unlicensed the awesome guidelines recommend a license like CC0 1.0 Universal.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aprovar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've missed to include the badge in the README file. Include any of the following items next to the awesome list title.
[![Awesome](https://awesome.re/badge.svg)](https://awesome.re)
[![Awesome](https://awesome.re/badge-flat.svg)](https://awesome.re)
[![Awesome](https://awesome.re/badge-flat2.svg)](https://awesome.re)
This is not an awesome list. Its just a list of resources by abp. Feels more like marketing than anything else. |
The title and description on the top and then having language translations would look nicer. Also there is no awesome badge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL to your list should end in #readme
, and the description should end in a period.
@@ -135,6 +135,7 @@ | |||
|
|||
## Platforms | |||
|
|||
- [ABP Framework](https://github.com/abpframework/awesome-abp) - The Web App Platform for .NET Developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ABP Framework](https://github.com/abpframework/awesome-abp) - The Web App Platform for .NET Developers | |
- [ABP](https://github.com/abpframework/awesome-abp#readme) - Web application platform for .NET developers. |
Try rewriting the keywords as ABP Community ✔️ instead of using slashes. abp.io/community ❌ |
What is lacking |
https://github.com/abpframework/awesome-abp
ABP Framework is "The Web App Platform for .NET Developers"
By submitting this pull request, I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines, and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.