-
-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows #3227
Add Windows #3227
Conversation
unicorn |
@sindresorhus Could you please review this PR everything seems ok to me. |
|
@sindresorhus Sorry to waste your time with this, I changed it. Now everything should be alright. |
@sindresorhus I think this is a rather urgent PR because the current link of the Windows platform does no longer exist (is broken). |
@sindresorhus I don't want to be annoying, but this PR is over a month old now. Over this period there were 3 approved reviews and I don't see any other problems apart from the one you pointed out. I would be so grateful if you could merge this. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see much issues with the list, it is quite good. But please note that awesome-lint is unhappy with the list for whatever reason; perhaps this deserves addressing?
Co-authored-by: Friedrich von Never <[email protected]>
I managed to resolve the linting issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 😎
I don't see any issues with this one. Also a great initiative to replace the disappeared list, thx @0PandaDEV ! |
@sindresorhus this is ready to merge. |
There are a bunch of typos in the list. I recommend running it through ChatGPT. |
The description should not start with the app name. |
@lutzh What do you think after my fix commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lutzh What do you think after my fix commit
ba69ec4
(#3227) based on the issues pointed out by sindresorhus?
Looks good to me, also well done fixing typos etc. in 0PandaDEV/awesome-windows@26d991a
But I'm not the one you need to convice, I had already approved even before 😄
While we're at it, would be great if you could review/approve #3152 😄
Yeah, I know that but if someone else approves the chance of sindresorhus approving is higher :)_ |
@sindresorhus ready to merge now really this time |
https://github.com/0pandaDEV/awesome-windows
This list is about awesome tools and apps for windows the goal is to replace its predecessor Awesome-Windows/Awesome which has not been updated in 3 years and recently vanished from GitHub.
My pull request reviews:
#3223 (review)
#3223 (review)
#3210 (review)
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List
. It should not contain the wordAwesome
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Awesome X
and a logo withAwesome X
. You can put the header image in a#
(Markdown header) or<h1>
.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. The casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.