[New utility]Sysinternals ZoomIt #35880
Conversation
jaimecbernardo
requested review from
crutkas,
DHowett and
ethanfangg
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jaimecbernardo |
@htcfreek , thanks for the comments 😄 I was waiting to really finalize the development before addressing any review. Thank you. |
| <value>Snip</value> | ||
| </data> | ||
| <data name="ZoomIt_SnipGroup.Description" xml:space="preserve"> | ||
| <value>Copy a region of the screen to the clipboard or enter the hotkey with the Shift key in the opposite mode to save it to a file.</value> |
There was a problem hiding this comment.
what if I set hotkey to Shift+ ? then save to file is unreachable?
There was a problem hiding this comment.
I've tried setting it to Shift+1. Pressing just 1 will save it to a file, similar to original ZoomIt behavior.
| <data name="ZoomIt_RecordGroup.Description" xml:space="preserve"> | ||
| <value>Record video of the unzoomed live screen or a static zoomed session by entering the recording hot key and finish the recording by entering it again. | ||
|
|
||
| To crop the portion of the screen that will be recorded, enter the hotkey with the Shift key in the opposite mode. |
There was a problem hiding this comment.
To finish recording you need to enter "Record video" (ctrl+5) hotkey, not (ctrl+shift+5). Might be worth pointing out, make it clear.
Also, same Q - what if I set hotkey that uses Shift or Alt?
There was a problem hiding this comment.
To finish recording you need to enter "Record video" (ctrl+5) hotkey, not (ctrl+shift+5). Might be worth pointing out, make it clear.
or is this a bug? Because alt+ctrl+5 both starts and ends recording of the window
There was a problem hiding this comment.
Took it from the original ZoomIt UI:
Actually Ctrl+Shift+5 is another mode. (crop and record)
There was a problem hiding this comment.
let me rephrase:
- if you enter crop and record mode (Ctrl + Shift + 5) , same hotkey (Ctrl + Shift + 5) does not end it. You have to pres Ctrl + 5
This is not the case for window record mode (Ctrl + Alt + 5). You end it with Ctrl + Alt + 5
There was a problem hiding this comment.
Should timer color be preserved? It is only correct after I change some other timer setting
DrawMode sometimes fails to start properly, it takes the cursor and "freezes" the desktop, but there's no actual cursor and nothing happens on clicking. I can exit that mode on Esc as expected. Type mode works as expected when this happens. Also, pressing a button to change color brings the cursor up and everything starts working.
My cursor gets stuck unvisible when:
ctrl+4 to enter live zoom mode
press 2, select area and either save or cancel
cursor is gone and stays gone until PT is closed
If I press Choose Font option, select anything and then try Ctrl+7 to Demo Type, it also opens Choose Font dialog
Forget about this, I just didn't know how to use DemoType
| <value>Timer Opacity</value> | ||
| </data> | ||
| <data name="ZoomIt_Break_TimerOpacity_10Percent.Content" xml:space="preserve"> | ||
| <value>10%</value> |
There was a problem hiding this comment.
does this need to be localized? 🤔
There was a problem hiding this comment.
Yes, different cultures present percents in a different way 🤷
Co-authored-by: Stefan Markovic <[email protected]>
@stefansjfw , thank you for the review. Not sure if I tested it exactly as you, but this seems to be original ZoomIt behavior too. Have you tested with original ZoomIt too? https://learn.microsoft.com/pt-pt/sysinternals/downloads/zoomit |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Summary of the Pull Request
This PR integrates the Sysinternals tool ZoomIt into PowerToys.
Has the PowerToys Settings page with the options allowed from ZoomIt.
Also updates some C++ dependencies.
Still missing/WIP:
PR Checklist