Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Update GPO infobar icon, improve some pages and fix bugs #33703

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Jul 7, 2024

Summary of the Pull Request

This PR updates the icon of the GPO managed info bars to a lock symbol.

Additionally this PR

  • fixes Behavior of CmdNotFound page when policy is configured.
  • improves order of info bars on PowerOcr page.
  • improves order of info bars on VCM page.
  • fixes the Awake page to use the correct enabled state if it is GPO configured.
  • improves the order of info bars on New+ page.

Important

PR Checklist

Detailed Description of the Pull Request / Additional comments

CmdNotFound module page

Old behavior
image

New behavior
image
image

PowerOCR page after change

image

VCM page after change

image

New+ page after changes

image

Validation Steps Performed

Local test build.

@htcfreek htcfreek self-assigned this Jul 7, 2024
@htcfreek htcfreek added Product-Settings The standalone PowerToys Settings application Status-Blocked We can't make progress due to a dependency or issue labels Jul 7, 2024

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review August 24, 2024 17:28
@htcfreek htcfreek changed the title [Settings] Update GPO infobar icon & improve some pages [Settings] Update GPO infobar icon, improve some pages and fix bugs Aug 24, 2024
@htcfreek htcfreek added Needs-Review This Pull Request awaits the review of a maintainer. and removed Status-Blocked We can't make progress due to a dependency or issue labels Aug 25, 2024
@htcfreek

This comment was marked as outdated.

@htcfreek

This comment has been minimized.

@htcfreek htcfreek added the Status-Blocked We can't make progress due to a dependency or issue label Oct 24, 2024
@htcfreek
Copy link
Collaborator Author

Blocked because ...

@htcfreek htcfreek removed the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 24, 2024
@htcfreek htcfreek removed the Status-Blocked We can't make progress due to a dependency or issue label Dec 7, 2024
@htcfreek
Copy link
Collaborator Author

htcfreek commented Dec 7, 2024

@jaimecbernardo , @crutkas
This PR is ready for review so far. If you like to merge #35880 and #35902 first, I have to update my PR to get it ready again.

@jaimecbernardo jaimecbernardo added the Needs-Review This Pull Request awaits the review of a maintainer. label Dec 9, 2024
@jaimecbernardo
Copy link
Collaborator

Thank you @htcfreek. We're just waiting for some clarity on the exact PRs you've mentioned for this release, but indeed we'd like to include those PRs in this release if we can and only after that we'd get this PR in.

@htcfreek htcfreek added the Status-Blocked We can't make progress due to a dependency or issue label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer. Product-Settings The standalone PowerToys Settings application Status-Blocked We can't make progress due to a dependency or issue
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants