-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opportunty card responsiveness #6082
Open
upsaurav12
wants to merge
13
commits into
layer5io:master
Choose a base branch
from
upsaurav12:internships-brands#5997
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
eb644dc
fix: opportunty card responsiveness
upsaurav12 9dcf750
fix:full time
upsaurav12 db7adb4
fix: cards responsive issue on mobile view
upsaurav12 ce8c583
fix: handbook responsice issue
upsaurav12 72c75c6
fix: single job page responsive issue
upsaurav12 feb3c60
fix: single job page responsive issue
upsaurav12 3f74e95
Delete src/sections/Community/Handbook/mentorships.js
upsaurav12 5731686
fix: single job page responsive issue
upsaurav12 3316145
Merge branch 'master' into internships-brands#5997
upsaurav12 946aa9e
Merge branch 'layer5io:master' into internships-brands#5997
upsaurav12 cbea4c2
fix: preview site
upsaurav12 5d791d4
fix: mentorship.js
upsaurav12 d006c2b
Merge branch 'master' into internships-brands#5997
upsaurav12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -115,14 +115,28 @@ p{ | |
} | ||
|
||
.full_time { | ||
.opportunity-card { | ||
flex-wrap: wrap; | ||
.opportunity-card { | ||
height: 12rem; | ||
} | ||
} | ||
|
||
@media screen and (max-width: 991px) { | ||
.opportunity-card { | ||
height: 12.5rem; | ||
width: 16rem; | ||
} | ||
} | ||
|
||
@media only screen and (max-width: 489px) { | ||
.opportunity-card { | ||
width: 100% !important; | ||
} | ||
} | ||
|
||
@media screen and (max-width: 700px) { | ||
.opportunity-card { | ||
width: 23rem; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. adding a perfect |
||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having a fix width, it better practice to with
max-width
that would manage the card size even in below the specified screen sizes.