-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opportunty card responsiveness #6082
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: upsaurav12 . <[email protected]>
@vishalvivekm, I have used |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 9dcf750 at: https://6737509357170daef02ac03e--layer5.netlify.app |
if i want to see if there is no other side effect how can i find that ?? |
@upsaurav12 adding it as an agenda item to the meeting minutes. |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit db7adb4 at: https://673b35c58ca641119437f383--layer5.netlify.app |
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit ce8c583 at: https://674da576a6b5e107d922b7ed--layer5.netlify.app |
Signed-off-by: upsaurav12 . <[email protected]>
@SAHU-01 @vishalvivekm i have made some changes in |
Signed-off-by: upsaurav12 . <[email protected]>
Signed-off-by: Saurav Upadhyay <[email protected]>
Signed-off-by: upsaurav12 . <[email protected]>
Signed-off-by: upsaurav12 . <[email protected]>
Signed-off-by: upsaurav12 . <[email protected]>
🚀 Preview for commit 5d791d4 at: https://67512d916e19bba79409ca69--layer5.netlify.app |
@mdkaifansari04 will you give this a review? |
merge conflicts... |
Signed-off-by: Saurav Upadhyay <[email protected]>
🚀 Preview for commit d006c2b at: https://675c6b0f28119a48dc77104a--layer5.netlify.app |
height: 12rem; | ||
} | ||
} | ||
|
||
@media screen and (max-width: 991px) { | ||
.opportunity-card { | ||
height: 12.5rem; | ||
width: 16rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having a fix width, it better practice to with max-width
that would manage the card size even in below the specified screen sizes.
|
||
@media screen and (max-width: 700px) { | ||
.opportunity-card { | ||
width: 23rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a perfect max-wdith
would get adjusted when screen size is changed, it automatically get adjusted. You can set one by trying different values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Else it is fine, just check if it can be done more better way using best practices
@mdkaifansari04 thank you for suggestions. |
You can try debugging it, also if you wanted to know more about If it has some predefined styles, try updating it or try passing styles directly into |
Description
This PR fixes #5997.
Notes for Reviewers
I have add
flex-wrap
property for1440px
. I have also shrink the width ofopporitunity-cards
to avoid the space due toflex-wrap
Video
cinnamon-2024-11-15T1847020530.mp4
Signed commits