Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable creation of custom performance metrics #2599

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

hub-bla
Copy link
Contributor

@hub-bla hub-bla commented Jul 25, 2024

Following PR contains:

  • creation of register_performance_metric decorator to register custom metrics provided by user
  • adjustment of performance_metrics to suite new way of function execution
  • adjustment of test_performance_metrics to test custom metric
  • documentation update for register_performance_metric usage

Closes Issue: #2234

@facebook-github-bot
Copy link
Contributor

Hi @hub-bla!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@tcuongd tcuongd self-requested a review October 18, 2024 14:09
Copy link
Collaborator

@tcuongd tcuongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, and with documentation too, thank you! Just one diff in the docs markdown that we should remove manually I think. Otherwise LGTM

13 0.500 0.10 0.524668
14 0.500 1.00 0.521130
15 0.500 10.00 0.522980
19:39:23 - cmdstanpy - INFO - Chain [1] start processing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you manually get rid of this diff pls, I assume it isn't supposed to change.

@tcuongd tcuongd merged commit 691a464 into facebook:main Oct 18, 2024
6 checks passed
MarcoGorelli pushed a commit to MarcoGorelli/prophet that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants