-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable creation of custom performance metrics #2599
Conversation
Hi @hub-bla! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, and with documentation too, thank you! Just one diff in the docs markdown that we should remove manually I think. Otherwise LGTM
docs/_docs/diagnostics.md
Outdated
13 0.500 0.10 0.524668 | ||
14 0.500 1.00 0.521130 | ||
15 0.500 10.00 0.522980 | ||
19:39:23 - cmdstanpy - INFO - Chain [1] start processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you manually get rid of this diff pls, I assume it isn't supposed to change.
Following PR contains:
register_performance_metric
decorator to register custom metrics provided by userperformance_metrics
to suite new way of function executiontest_performance_metrics
to test custom metricregister_performance_metric
usageCloses Issue: #2234