Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function #29179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function #29179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/src/builders/extract-i18n/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export async function execute(
// eslint-disable-next-line @typescript-eslint/no-explicit-any
checkFileSystem as any,
extractionResult.messages,
'warning',
normalizedOptions.i18nOptions.i18nDuplicateTranslation || 'warning',
// eslint-disable-next-line @typescript-eslint/no-explicit-any
extractionResult.basePath as any,
);
Expand Down
2 changes: 2 additions & 0 deletions packages/angular/build/src/utils/i18n-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/

import { DiagnosticHandlingStrategy } from '@angular/localize/tools';
import path from 'node:path';
import type { TranslationLoader } from './load-translations';

Expand All @@ -28,6 +29,7 @@ export interface I18nOptions {
flatOutput?: boolean;
readonly shouldInline: boolean;
hasDefinedSourceLocale?: boolean;
i18nDuplicateTranslation?: DiagnosticHandlingStrategy;
}

function normalizeTranslationFileOption(
Expand Down
Loading