Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function #29179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Algoritm211
Copy link

@Algoritm211 Algoritm211 commented Dec 18, 2024

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Current behaviour is described inside this issue - #23635

Issue Number: #23635

What is the new behavior?

Now we can add different values according to the i18nDuplicateTranslation option

i18nDuplicateTranslation?: I18NTranslation;
and have corresponding output, not hardcoded warning

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented Dec 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 18, 2024
@Algoritm211 Algoritm211 changed the title feat: provide i18nDuplicateTranslation config value to checkDuplicateMessages function bugfix: provide i18nDuplicateTranslation config value to checkDuplicateMessages function Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant