-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark some specific furnitures/terrains examine as always allowed in faction territory #78631
base: master
Are you sure you want to change the base?
Conversation
Regarding prisoners problem: probably they should be upset, but not THAT upset. Removing the barricade should lower their opinion towards player, but not to the point of attacking on sight after getting in. |
For better or worse, there are only two levels of granularity in 'ownership zones'. We could offset their relationship status to absorb the first offense, but that would be prone to breakage if the values change in the future. It would also not work well if the player failed at lockpicking, since each attempt would accrue additional relationship losses. |
Oh this is embarrassing. I went to go find who added this mapgen to ask their intention, but that's you! I feel like the prisoners being a bit smug (at owning the place) and peeved (from the fact you broke in) is appropriate for the prison setting. We could limit their ownership to one OMT, set them to initially allow you to touch anything (allowing you to break in/lockpick your way in), and then have an EOC that fires when you actual enter their OMT which flips it to not allowed. It seems a little jank, but it does emulate the player's unexpected, unwanted entry into their safe area. Could also add a new line/topic to the first conversation you have with their boss, mentioning that they're surprised/peeved at how you got in. |
Yeah, that would be VERY cool. |
Need a rebase to pick up the cross-mod conflict fix. |
Summary
Bugfixes "Mark some specific furnitures/terrains examine as always allowed in faction territory"
Purpose of change
Describe the solution
Add a flag
FREE_TO_EXAMINE
to the common furniture/terrain that should always be examinable.If that flag is present, the locals will never care about you examining it.
Added to the following furniture/terrain:
Translocator (magiclysm)
Exodii sign at their main base and all other
f_sign
by extensionExodii sign at their barns (not faction territory atm, but just in case)
Describe alternatives you've considered
Tying it to the examine actor/function
Uh it turns out that a flag was incredibly simple, so the flag was chosen instead.
Testing
Spawned a sign at a faction territory
Examined glass display case, got warned
Examined sign, no warning
Additional context
#77239 (comment) is a problem with the design. There's no way in and the prisoners SHOULD be upset about you forcing your way in (they're barricaded to keep the zombies out). I don't know what to do there 🤷
This PR was way easier than I thought.