-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate item contents description in the examine display #78401
Open
moxian
wants to merge
6
commits into
CleverRaven:master
Choose a base branch
from
moxian:examine-stack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Info / User Interface
Game - player communication, menus, etc.
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Dec 7, 2024
There's very little performance cost to following that pointer, so feel free to combine the code to improve maintainability. |
github-actions
bot
added
Items: Containers
Things that hold other things
astyled
astyled PR, label is assigned by github actions
and removed
astyled
astyled PR, label is assigned by github actions
labels
Dec 9, 2024
moxian
force-pushed
the
examine-stack
branch
from
December 16, 2024 06:02
1f1024a
to
cd01c9c
Compare
clang-tidy complains about my code, but from a different pr. I'll pr a fix, separately. |
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Info / User Interface
Game - player communication, menus, etc.
Items: Containers
Things that hold other things
json-styled
JSON lint passed, label assigned by github actions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Deduplicate item contents description in the examine display"
Purpose of change
If we have several identical items in our pockets, each individual item is listed separately in the
e
xamine display.This is unwieldly. See:
Describe the solution
Merge the individual items if they are identical into a single one. This is already how it works for pocket contents, I'm doing the same thing to the item contents now.
Describe alternatives you've considered
N/A
Testing
Additional context
This still looks a bit silly with liquid contents (the liquid's description is duplicated), but at least that's not a regression.