Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary support for Python 3.12a7. #97

Closed
wants to merge 1 commit into from

Conversation

icemac
Copy link
Member

@icemac icemac commented Apr 17, 2023

No description provided.

@icemac icemac self-assigned this Apr 17, 2023
@icemac
Copy link
Member Author

icemac commented Apr 17, 2023

o no, we have breaking tests on Python 3.12a7.

@icemac
Copy link
Member Author

icemac commented Apr 18, 2023

And of course the test failures do not happen locally neither on MacOS Intel nor on M2.

I have no idea how to solve this.
@dataflake Do you have any suggestion?

@icemac icemac marked this pull request as draft April 18, 2023 06:06
@dataflake
Copy link
Member

The issues are described at zopefoundation/meta#181. Both zc.buildout and setuptools are at fault but there is no reaction to the issues I have filed.

The only suggestion I have would be to not install zope.proxy via setup_requires to get at the C header files, but to just copy them straight into zope.security. This has the drawback of them going out of sync with zope.proxy but I think it would get rid of the build issue. Or maybe there's a saner way to get at those header files during the build.

@d-maurer
Copy link
Contributor

d-maurer commented Apr 18, 2023 via email

@d-maurer
Copy link
Contributor

d-maurer commented Apr 18, 2023 via email

@dataflake
Copy link
Member

The test (3.12.0-alpha.7, ubuntu-20.04) is also failing which likely is not Mac related and likely not due to setuptools/buildout problems.

This is already understood. The issue I am talking about cropped up at zopefoundation/AccessControl#139. I think the way dependency header files are provided before the build step in some packages is the problem. Packages that have a copy of their dependencies' headers don't show the issue.

@icemac
Copy link
Member Author

icemac commented Apr 19, 2023

@dataflake wrote:

The only suggestion I have would be to not install zope.proxy via setup_requires to get at the C header files, but to just copy them straight into zope.security

I implemented this in #98. I am planning to release that changes as a dev version as some tests break but it should unblock us in AccessControl.

@icemac
Copy link
Member Author

icemac commented Apr 19, 2023

Superseded by #98.

@icemac icemac closed this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants