New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem: unsecured websocket is rarely used in production #3695

Merged

bluca merged 1 commit into zeromq:master from somdoron:tls

Oct 2, 2019

Member

somdoron commented Sep 29, 2019 •

edited

Loading

Solution: support websocket with tls (wss)

Support CMake (added to WebSocket transport progress #3581)
Support self-signed certificates
Move credentials to connecter and listener
Validate certificates when set with setsockopt (added to WebSocket transport progress #3581)
Load certificate
Change the option to enable-tls

somdoron mentioned this pull request

Will curve security be implemented? zeromq/jszmq#8

Open

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

external/tlse/tlse.c Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/ws_connecter.cpp Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

src/ws_listener.cpp Show resolved Hide resolved

Member

bluca commented Sep 30, 2019

Nice! There's a merge conflict

somdoron force-pushed the tls branch 11 times, most recently from 977b643 to a639b8d Compare

October 1, 2019 19:47

bluca reviewed

View reviewed changes

include/zmq.h Outdated Show resolved Hide resolved

somdoron force-pushed the tls branch from a639b8d to 7c20ad8 Compare

October 1, 2019 20:04

Member Author

somdoron commented Oct 1, 2019

This is ready to be merged, some comments:

I had to add another build to travis, because a minimum version of gnutls is required, which only available in xenial
TLS cannot be enabled with CMake, I added to WebSocket transport progress #3581
Some minor fixes are needed, I added them to WebSocket transport progress #3581

Member

bluca commented Oct 1, 2019

aren't we using xenial everywhere by now? anything earlier is deprecated

Member Author

somdoron commented Oct 1, 2019

No... still trusty

somdoron mentioned this pull request

WebSocket transport progress #3581

Open

27 tasks

somdoron force-pushed the tls branch from 7c20ad8 to 2da596e Compare

October 1, 2019 21:00

Member

bluca commented Oct 1, 2019

Looks like Windows builds are all failing, could you please have a look?

bluca reviewed

View reviewed changes

src/session_base.cpp Outdated Show resolved Hide resolved

somdoron force-pushed the tls branch from 2da596e to aa20889 Compare

October 1, 2019 22:46

sonatype-lift bot reviewed

View reviewed changes

src/session_base.cpp Show resolved Hide resolved


          problem: unsecured websocket is rarely used in production

7296fb5

Solution: support websocket with tls (wss)

somdoron force-pushed the tls branch from aa20889 to 7296fb5 Compare

October 2, 2019 05:58

somdoron changed the title ~~WIP: problem: unsecured websocket is rarely used in production~~ problem: unsecured websocket is rarely used in production

bluca merged commit 9bb6b21 into zeromq:master

Elsaligi commented Dec 9, 2022 •

edited

Loading

This is ready to be merged, some comments:

I had to add another build to travis, because a minimum version of gnutls is required, which only available in xenial

TLS cannot be enabled with CMake, I added to WebSocket transport progress #3581

Some minor fixes are needed, I added them to WebSocket transport progress #3581

Is there a python example available as reference to start with wss..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet