Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for RTD addons #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add compatibility for RTD addons #129

wants to merge 2 commits into from

Conversation

daltzctr
Copy link

@daltzctr daltzctr commented Aug 6, 2024

No description provided.

TheTripleV
TheTripleV approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@TheTripleV TheTripleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try it out on frc docs before tagging to test this?

@sciencewhiz
Copy link
Contributor

Can you try it out on frc docs before tagging to test this?

Note that frc-docs defines ogp_site_url so it would never fall into this code.

@sciencewhiz
Copy link
Contributor

This can be tested with the PR build, now that RTD doesn't inject it any more. Just need #132 merged to fix the RTD build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheTripleV TheTripleV TheTripleV approved these changes

@sciencewhiz sciencewhiz sciencewhiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltzctr @sciencewhiz @TheTripleV