-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script for checking codeblock coverage #2731
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit bd3b68a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an option to link to the non covered parts?
That's what --verbose does, unless I'm misunderstanding? |
Should check for when no arguments are provided and display help |
Ah, it's working it just doesn't say anything, okay I'll fix both of those things |
I'm concerned about this script.
|
Implemented both of @spacey-sooty requests. |
I do not think this should be a CI thing, or at least it shouldn't fail PRs. It's intended to be a tool for people to just check if there are any glaring gaps in language support. I can understand wanting it in Sphinx's API but I have never used that, so I used regex, if it's absolutely necessary to not be regex that's fine |
I feel like this is a recipe to have documentation fall further behind for Python and make C++ start falling behind substantially. I can easily see a PR getting through with C++ to be done later then it never being done (its happened before) |
I feel like if the tool has proper warnings (which I'm happy to add more of) then not putting it in over the possibilities of misuse would be a bad decision, because it would still be useful |
I wrote a simple tool for getting data on how many codeblocks cover each language. By default it will check for Python, C++, and Java, but the RegEx is generated at runtime based on what languages you pass in, so it still works for checking the coverage of other languages.
This script contains its own documentation on how to run it, but I'm happy to add a page to the frc-docs contributing guide if needed.
(I made a similar PR earlier but I wanted to make a new one as that one contains differing information from this newer version of the script)