Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hal] Add CAN device type for servo controllers #7556

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[hal] Add CAN device type for servo controllers #7556

wants to merge 2 commits into from
+4 −0

Conversation

jfabellera
Copy link
Contributor

i.e. REV Servo Hub

@jfabellera jfabellera requested a review from a team as a code owner December 16, 2024 18:29
@github-actions github-actions bot added the component: hal Hardware Abstraction Layer label Dec 16, 2024
@ThadHouse
Copy link
Member

@Kevin-OConnor Is this ok for your documentation? We're also going to need to update the frc docs page for this.

@Kevin-OConnor
Copy link
Contributor

The FRC docs page already has this allocation, I just didn't remember to do the WPILib side as well.

ThadHouse
ThadHouse previously approved these changes Dec 16, 2024
View reviewed changes
@ThadHouse
Copy link
Member

https://github.com/wpilibsuite/allwpilib/blob/main/hal/src/main/java/edu/wpi/first/hal/CANAPITypes.java#L14

Can you add this to Java as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThadHouse ThadHouse ThadHouse approved these changes

Assignees
No one assigned
Labels
component: hal Hardware Abstraction Layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfabellera @ThadHouse @Kevin-OConnor