Change Command Scheduler to fix iterator invalidation bug in C++ Command Scheduler (Reduced Copy of PR #6593) #7554
+95
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the robot.py commandScheduler implementation. This way we avoid an iterator invalidation bug when a command ends and we delete it. Because we are only copying a stack(most probably) pointer array, it shouldn't have a big impact on performance.
Co-authored-by: Joseph Eng <[email protected]>
Co-Authored-By: Joseph Eng <[email protected]>
github-actions
bot
added
the
component: command-based
Co-Authored-By: Ryan Blue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the huge impact changing the Java
Command Schedulercode has, this draft PR removes all the changes made to the Java side and only includes the changes made to C++ from the #6593 PR.This is still being discussed in the FRC Discord server