Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[robotpy parity] Write a deploy.json log file when deploying code #690

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[robotpy parity] Write a deploy.json log file when deploying code #690

wants to merge 11 commits into from

Conversation

spacey-sooty
Copy link
Contributor

Resolves #689

@spacey-sooty spacey-sooty marked this pull request as ready for review December 7, 2023 05:51
@ThadHouse
Copy link
Member

You need to be using a gradle task for this, with properly mapped inputs and outputs. Additionally, the output needs to go into somewhere in the build folder. Everything needs to be fully cross platform. This should also use grgit for the git commands, using the same version in the gradle-versioning-plugin we publish. It also needs to not fail if the project is not a git repo.

spacey-sooty

This comment was marked as outdated.

Sign in to view

@spacey-sooty
Copy link
Contributor Author

This way this will write the deploy file to the output dir and we can add to the build template a StaticFileDeploy object

spacey-sooty added a commit to spacey-sooty/vscode-wpilib that referenced this pull request Mar 28, 2024
@spacey-sooty
Update build templates for gradlerio deploy files
32e3a8c 
Requires wpilibsuite/GradleRIO#690
@spacey-sooty spacey-sooty mentioned this pull request Mar 28, 2024
Open
spacey-sooty and others added 7 commits June 30, 2024 20:16
@spacey-sooty
start working on deploy data
e0b462a
@spacey-sooty
create file to be deployed
d63d80a 
just need to get the data

get git data

write to build/ instead
@spacey-sooty
start switching to proper gradle way
32cbe68 
- grgit not fully used see ajoberstar/grgit#398
- doesn't fully use tasks properly I don't think
- file needs to be properly set to output dir

revert plugin changes

fix: use gradle output dir

call the thingy
@spacey-sooty
Use grgit for hash and branchname
b1866f5 
requires ajoberstar/grgit#399

Try use grgit to check if in git repo

not sure if this works see ajoberstar/grgit#397

fix grgit
@spacey-sooty
should be working now
a2c42c7
@spacey-sooty
pass args to grgit.open
e3dcd14 
naming
@spacey-sooty
jgit
3e09be4
@spacey-sooty
Copy link
Contributor Author

@ThadHouse can you review this?

ThadHouse
ThadHouse reviewed Dec 1, 2024
View reviewed changes
src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java
deployFile = new File(path);
}

public void setGitDirectory(String dir) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a string property

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a StringProperty class in the Gradle API?

ThadHouse
ThadHouse reviewed Dec 1, 2024
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@spacey-sooty
review fixes
91d1498 
Signed-off-by: Jade Turner <[email protected]>
@spacey-sooty
working raaa
d2f02b6 
Signed-off-by: Jade Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThadHouse ThadHouse ThadHouse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

robotpy parity: write deploy.json to rio on deploy?
2 participants
@spacey-sooty @ThadHouse