[robotpy parity] Write a deploy.json log file when deploying code #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacey-sooty
force-pushed
the
deploy_data
branch
from
49a6c50 to
2c819e6
Compare
|
You need to be using a gradle task for this, with properly mapped inputs and outputs. Additionally, the output needs to go into somewhere in the build folder. Everything needs to be fully cross platform. This should also use grgit for the git commands, using the same version in the gradle-versioning-plugin we publish. It also needs to not fail if the project is not a git repo. |
spacey-sooty
force-pushed
the
deploy_data
branch
from
b6d08c1 to
5d47416
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
spacey-sooty
force-pushed
the
deploy_data
branch
from
5d47416 to
03c70fa
Compare
|
This way this will write the deploy file to the output dir and we can add to the build template a StaticFileDeploy object |
spacey-sooty
commented
Mar 27, 2024
src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java
Outdated
Show resolved
Hide resolved
spacey-sooty
added a commit
to spacey-sooty/vscode-wpilib
that referenced
this pull request
Mar 28, 2024
spacey-sooty
force-pushed
the
deploy_data
branch
from
ff82058 to
df1512a
Compare
just need to get the data get git data write to build/ instead
- grgit not fully used see ajoberstar/grgit#398 - doesn't fully use tasks properly I don't think - file needs to be properly set to output dir revert plugin changes fix: use gradle output dir call the thingy
requires ajoberstar/grgit#399 Try use grgit to check if in git repo not sure if this works see ajoberstar/grgit#397 fix grgit
naming
spacey-sooty
force-pushed
the
deploy_data
branch
from
8bbe76f to
3e09be4
Compare
|
@ThadHouse can you review this? |
ThadHouse
reviewed
Dec 1, 2024
src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java
Outdated
Show resolved
Hide resolved
ThadHouse
reviewed
Dec 1, 2024
src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java
Outdated
Show resolved
Hide resolved
ThadHouse
reviewed
Dec 1, 2024
ThadHouse
reviewed
Dec 1, 2024
src/main/java/edu/wpi/first/gradlerio/deploy/CreateLogFileTask.java
Outdated
Show resolved
Hide resolved
ThadHouse
reviewed
Dec 1, 2024
| deployFile = new File(path); | ||
| } | ||
|
|
||
| public void setGitDirectory(String dir) { |
There was a problem hiding this comment.
This should be a string property
There was a problem hiding this comment.
I can't find a StringProperty class in the Gradle API?
ThadHouse
reviewed
Dec 1, 2024
ThadHouse
reviewed
Dec 1, 2024
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #689