Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration with DOM's cloning steps #10859

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

annevk
Copy link
Member

@annevk annevk commented Dec 12, 2024

@annevk annevk requested a review from smaug---- December 16, 2024 11:06
Copy link
Member

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay getting to this half (as well).

This looks fine to me with a single-word nit (see below).

source Show resolved Hide resolved
annevk added a commit to whatwg/dom that referenced this pull request Dec 17, 2024
Strictly speaking this should be an editorial change, but as it's fairly significant not marking it as such. This improves integration with HTML as well.

All the arguments are exported as HTML needs them as well. And they are named parameters now for clarity.

Corresponding HTML PR: whatwg/html#10859.

Fixes #1219. Closes #1220.
@annevk annevk merged commit f3c4fe0 into main Dec 17, 2024
2 checks passed
@annevk annevk deleted the annevk/cloning-steps branch December 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants