Fix the calculation for estimated gas price #3117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5cb2631 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@piersy is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
The gas price returned by the rpc is base_fee + max_priority_fee. So we shouldn't add the max_priority_fee onto that value since it's already included. Also the logic used by viem for applying the multiplier is to only apply the multiplier to the base fee and not the priority fee, so we match that approach here.
piersy
force-pushed
the
piersy/fix_gas_price_estimation
branch
from
819f98b to
af51ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
estimateFeesPerGasto handle both the valuesreturned by the Celo L1 and also the values that will be returned
by the L2 Celo implementation.
Also removes the use of the viem multiplier for Celo L1 gas
calculations since the Celo L1 node already doubles the base fee.
Changes explained in detail:
Note the default
viemMultiplieris 1.2 and the defaultceloMultiplieris 2.The current gas
maxFeePerGassuggested by viem (before this PR) is this:((baseFee * celoMultiplier) * viemMultiplier) + suggestedTip((baseFee+suggestedTip) * viemMultiplier) + suggestedTipWith this PR we get:
(baseFee * celoMultiplier) + suggestedTip(baseFee * viemMultiplier) + suggestedTip