feat: support inner not, not in simple types #61

vankop · 2019-09-28T16:00:36Z

This PR contains a:

Motivation / Use-Case

fixes #65

#42
part of 1st proposal.

Breaking Changes

no

Additional Info

Nothing

codecov · 2019-09-28T16:02:51Z

Codecov Report

Merging #61 into master will decrease coverage by 0.56%.
The diff coverage is 94.26%.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   98.12%   97.56%   -0.57%     
==========================================
  Files           5        6       +1     
  Lines         639      697      +58     
  Branches      267      298      +31     
==========================================
+ Hits          627      680      +53     
- Misses         12       15       +3     
- Partials        0        2       +2

Impacted Files	Coverage Δ
src/validate.js	`100.00% <ø> (ø)`
src/ValidationError.js	`96.67% <89.06%> (-0.99%)`	⬇️
src/util/hints.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d7cbd...b75bdcd. Read the comment docs.

src/util/Range.js

test/__snapshots__/index.test.js.snap

alexander-akait

Good job, let's avoid here logic for not and do this on other PR?

vankop · 2019-09-28T21:03:25Z

what is problem with CI? coverage decrease?

alexander-akait · 2019-09-30T11:08:01Z

Yep, don't know why, you can ignore this

src/ValidationError.js

vankop · 2019-10-03T20:33:09Z

@evilebottnawi I suggest to split not functionality in several PRs since logic for arrays and objects need a lot of tests. I will add tests too this PR also.

vankop · 2019-10-04T15:25:17Z

@evilebottnawi I think this is ready to review 😁

alexander-akait · 2019-10-09T12:19:52Z

/cc @vankop sorry for delay, can we fix it #65 in a separate PR for chanelog and clean git history? Anyway thanks for good job!

vankop · 2019-10-09T12:22:30Z

@evilebottnawi I can do it, but later. Busy right now.

alexander-akait · 2019-10-09T12:28:46Z

@vankop great

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap

alexander-akait · 2019-10-17T11:31:52Z

@vankop let's wait a bit with this, at the moment I'm adding JSDoc for all project and continue after this 👍

vankop · 2019-10-17T11:33:24Z

TypeScript 🤩🤗

alexander-akait · 2019-11-12T12:41:29Z

/cc @vankop we can continue development too 😄

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap # test/index.test.js

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap

npm audit fix npm audit fix one more

vankop · 2020-04-16T20:58:27Z

@evilebottnawi so much work is done =) need rereview

alexander-akait

Oh, a lot of changes, very hard to review, maybe we can separate this PR on parts? Also it will be good for git history?

alexander-akait · 2020-04-17T15:39:23Z

@vankop friendly ping

# Conflicts: # package-lock.json

vankop · 2020-04-17T15:51:33Z

I will try to reduce

alexander-akait · 2020-04-17T15:52:32Z

Will be great, anyway thanks for a job, if you can't reduce ping me and I will try to review this big PR

feat: support not for numbers, "smart" inner not, "smart" number range

20f0059

fix: comment in test case

61f28f8

alexander-akait reviewed Sep 28, 2019

View reviewed changes

src/util/Range.js Outdated Show resolved Hide resolved

alexander-akait reviewed Sep 28, 2019

View reviewed changes

test/__snapshots__/index.test.js.snap Outdated Show resolved Hide resolved

alexander-akait reviewed Sep 28, 2019

View reviewed changes

chore: remove "smart" numbers logic

e248c18

vankop changed the title ~~feat: support not for numbers, "smart" inner not, "smart" number range~~ feat: support inner not Sep 28, 2019

vankop added 4 commits September 28, 2019 23:42

Merge branch 'master' into smart-not-case

6197ad6

feat: apply not for numbers

491af16

test: add tests, some comments

5c0d4b4

fix: snapshot update

92dc0a9

vankop changed the title ~~feat: support inner not~~ feat: support inner not, not in numbers Sep 28, 2019

Merge branch 'master' into smart-not-case

567ce85

alexander-akait reviewed Sep 30, 2019

View reviewed changes

src/ValidationError.js Show resolved Hide resolved

vankop added 3 commits October 1, 2019 19:40

chore: merge master

1096dc8

Merge remote-tracking branch 'origin/smart-not-case' into smart-not-case

63b7dc5

feat: apply not for boolean, string

8f206df

vankop added 2 commits October 4, 2019 00:16

fix: webpack#65 , add tests for stringHints

85b3207

test: add multipeOf, empty string tests

e9cb823

vankop changed the title ~~feat: support inner not, not in numbers~~ feat: support inner not, not in simple types Oct 4, 2019

Merge branch 'master' into smart-not-case

b1778c4

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap

vankop added 3 commits April 16, 2020 23:24

Merge branch 'master' into smart-not-case

62d1367

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap # test/index.test.js

Merge branch 'master' into smart-not-case

c1b2c49

# Conflicts: # src/ValidationError.js # test/__snapshots__/index.test.js.snap

fix: publsh missing declarations

36d334d

npm audit fix npm audit fix one more

vankop force-pushed the smart-not-case branch from 7f1f35b to 36d334d Compare April 16, 2020 20:49

fix: ship latest babel with esm imports

ca93eaa

alexander-akait reviewed Apr 17, 2020

View reviewed changes

Merge branch 'master' into smart-not-case

b75bdcd

# Conflicts: # package-lock.json

This was referenced May 15, 2020

feat: separate hints #100

Merged

feat: smart not case #101

Merged

vankop closed this May 18, 2020

vankop deleted the smart-not-case branch May 18, 2020 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support inner not, not in simple types #61

feat: support inner not, not in simple types #61

vankop commented Sep 28, 2019 •

edited

Loading

codecov bot commented Sep 28, 2019 •

edited

Loading

alexander-akait left a comment

vankop commented Sep 28, 2019

alexander-akait commented Sep 30, 2019 •

edited

Loading

vankop commented Oct 3, 2019

vankop commented Oct 4, 2019

alexander-akait commented Oct 9, 2019

vankop commented Oct 9, 2019

alexander-akait commented Oct 9, 2019

alexander-akait commented Oct 17, 2019

vankop commented Oct 17, 2019

alexander-akait commented Nov 12, 2019

vankop commented Apr 16, 2020

alexander-akait left a comment

alexander-akait commented Apr 17, 2020 •

edited

Loading

vankop commented Apr 17, 2020

alexander-akait commented Apr 17, 2020

feat: support inner not, not in simple types #61

feat: support inner not, not in simple types #61

Conversation

vankop commented Sep 28, 2019 • edited Loading

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Sep 28, 2019 • edited Loading

Codecov Report

alexander-akait left a comment

Choose a reason for hiding this comment

vankop commented Sep 28, 2019

alexander-akait commented Sep 30, 2019 • edited Loading

vankop commented Oct 3, 2019

vankop commented Oct 4, 2019

alexander-akait commented Oct 9, 2019

vankop commented Oct 9, 2019

alexander-akait commented Oct 9, 2019

alexander-akait commented Oct 17, 2019

vankop commented Oct 17, 2019

alexander-akait commented Nov 12, 2019

vankop commented Apr 16, 2020

alexander-akait left a comment

Choose a reason for hiding this comment

alexander-akait commented Apr 17, 2020 • edited Loading

vankop commented Apr 17, 2020

alexander-akait commented Apr 17, 2020

vankop commented Sep 28, 2019 •

edited

Loading

codecov bot commented Sep 28, 2019 •

edited

Loading

alexander-akait commented Sep 30, 2019 •

edited

Loading

alexander-akait commented Apr 17, 2020 •

edited

Loading