Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bench js api #8763

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: bench js api #8763

wants to merge 10 commits into from

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 18, 2024

Summary

Using codspeed to bench JS API.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit de6b573
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67639ba1d082b10008d162fb

@SyMind SyMind force-pushed the bench-js branch 4 times, most recently from 7942e3a to 2901e34 Compare December 18, 2024 09:41
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #8763 will not alter performance

Comparing bench-js (de6b573) with main (0e749f0)

Summary

✅ 1 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main bench-js Change
🆕 Traverse module graph by dependencies N/A 1.5 ms N/A

@SyMind SyMind force-pushed the bench-js branch 2 times, most recently from 46f8145 to fb83c0d Compare December 18, 2024 11:19
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Dec 18, 2024

I was wondering if codspeed can show both JS stack and rust stack at the same time. If so, we can just port benchmark tests to JS instead of relying on porting JavaScript default value logic to the rust side.

@SyMind
Copy link
Member Author

SyMind commented Dec 18, 2024

@h-a-n-a My goal is to find a way that can accurately bench the JS API

@adriencaccia
Copy link

Hey @SyMind, it seems you are uploading multiple times per workflow, but CodSpeed does not support multiple uploads yet, so you have to ensure that you only call the CodSpeedHQ/Action once per workflow, across all jobs.

In your case, if you want to have both js and rust benchmarks, you would need to run them both in the unique call to the action, something along those lines:

run: |
  cargo codspeed bench
  pnpm bench:ci

The support for matrices and multi-part upload is in the works.

@SyMind SyMind force-pushed the bench-js branch 6 times, most recently from e2dc375 to 2cad1a8 Compare December 19, 2024 01:50
@SyMind SyMind force-pushed the bench-js branch 2 times, most recently from 0aac706 to c51a2ce Compare December 19, 2024 02:35
@SyMind SyMind changed the title feat: bench js feat: bench js api Dec 19, 2024
@SyMind SyMind marked this pull request as ready for review December 19, 2024 04:20
@SyMind SyMind requested a review from jerrykingxyz as a code owner December 19, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants