-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bench js api #8763
base: main
Are you sure you want to change the base?
feat: bench js api #8763
Conversation
✅ Deploy Preview for rspack canceled.
|
7942e3a
to
2901e34
Compare
CodSpeed Performance ReportMerging #8763 will not alter performanceComparing Summary
Benchmarks breakdown
|
46f8145
to
fb83c0d
Compare
I was wondering if codspeed can show both JS stack and rust stack at the same time. If so, we can just port benchmark tests to JS instead of relying on porting JavaScript default value logic to the rust side. |
@h-a-n-a My goal is to find a way that can accurately bench the JS API |
Hey @SyMind, it seems you are uploading multiple times per workflow, but CodSpeed does not support multiple uploads yet, so you have to ensure that you only call the In your case, if you want to have both js and rust benchmarks, you would need to run them both in the unique call to the action, something along those lines: run: |
cargo codspeed bench
pnpm bench:ci The support for matrices and multi-part upload is in the works. |
e2dc375
to
2cad1a8
Compare
0aac706
to
c51a2ce
Compare
Summary
Using codspeed to bench JS API.
Checklist