Fix release build job #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoarnold
force-pushed
the
leoarnold/fix/release
branch
from
42e07ff to
6795de4
Compare
The CSS code for the `flipflop` web interface is generated by the rake tast `assets:compile`, hence it should not be commited to the repository at all, because its content depends on the actual versions of gems activated at build time. We therefore remove it and add it to `.gitignore`. Furthermore, in voormedia#40 the stylesheet file was renamed from `_flipflop.css` to `_flipflop.html.erb` which is problematic because - the file is not HTML - the file is not a template - the filename in `rake assets:compile` was not adjusted, so the generated content is now ignored and instead the commited content is used. We revert the renaming of the file and use `render(file: ...` to insert its contents into the view, thereby fixing all issues.
leoarnold
force-pushed
the
leoarnold/fix/release
branch
from
6795de4 to
9f2c407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS code for the
flipflopweb interface is generatedby the rake task
assets:compile, hence it should notbe committed to the repository at all, because its content
depends on the actual versions of gems activated at build time.
We therefore remove it and add it to
.gitignore.Furthermore, in #40 the stylesheet file was renamed from
_flipflop.cssto_flipflop.html.erbwhich is problematic becauserake assets:compilewas not adjusted,so the generated content is now ignored and instead
the committed content is used.
We revert the renaming of the file and use
render(file: ...to insert its contents into the view, thereby fixing all issues.