RSDK-9566: Monitor CPU/Memory usage of viam-server and modular processes with FTDC. #4642

dgottlieb · 2024-12-18T18:53:11Z

In this patch, we just output raw "counters" for things like cpu/system time. I'm going to make a subsequent change to the ftdc parsing to treat those special to generate the actual cpu usage graphs.

…ses with FTDC.

cheukt

generally looks good, q around behavior on other systems

cheukt · 2024-12-18T21:44:30Z

ftdc/sys/sys.go

+)
+
+// On linux, getting the page size is a system call. Cache the page size for the entirety of the
+// progarm lifetime. As opposed to calling it each time we wish to compute the resident memory a


Suggested change

// progarm lifetime. As opposed to calling it each time we wish to compute the resident memory a

// program lifetime. As opposed to calling it each time we wish to compute the resident memory a

cheukt · 2024-12-18T21:58:19Z

module/modmanager/manager.go

+	// Turn on process cpu/memory diagnostics for the module process. If there's an error, we should
+	// continue normally, just without FTDC. The control flow for that is a bit messy, so we use a
+	// lambda to leverage early-returns.
+	func() {


minor: could just factor out into a function then?

cheukt · 2024-12-18T22:05:04Z

ftdc/sys/sys.go

+}
+
+// Stats returns Stats.
+func (sys *UsageStatser) Stats() any {


what does Stats() return on a mac or possibly a windows machine?

I expect the constructor to fail on both -- therefore these objects would never get registered with FTDC. And FTDC would never call Stats. But if the constructor did succeed, I'd expect the Stat call on line 80 to return an error and we'd just get 0 values out.

RSDK-9566: Monitor CPU/Memory usage of viam-server and modular proces…

c959bc8

…ses with FTDC.

viambot added the safe to test This pull request is marked safe to test from a trusted zone label Dec 18, 2024

cleanup

eaa6b0a