[RSDK-9551] remove builtin pi5 model #4634
Open
+0
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
|
you probably want to merge before migration, so that a user doesn't accidentally add the builtin after you've migrated but before you've deleted. I'd recommend to merge Friday afternoon or Monday morning, and run the migration sometime Tuesday morning around when the new rdk is released |
martha-johnston
approved these changes
Dec 16, 2024
just checked on the branch in github to confirm it was removed https://github.com/JohnN193/rdk/tree/remove-pi5/components/board |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://viam.atlassian.net/browse/RSDK-9551
this pr removes the builtin pi5 in favor of having users use the pi5 module.
will not be merged until after users have been migrated to the module