Replace API endpoint and speech synthesizer #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
requested changes
Oct 18, 2020
Comment on lines
15
to
18
| "\t$SpeechSynth = New-Object -ComObject SAPI.SpVoice", | ||
| "\t$URI = 'https://catfact.ninja/fact'", | ||
| "\t$CatFact = Invoke-WebRequest -Uri $URI | ConvertFrom-Json | Select-Object -ExpandProperty fact", | ||
| "\t$SpeechSynth.Speak(\"Did you know? $Catfact\") | Out-Null", |
There was a problem hiding this comment.
@johnheusinger can you add a note into either the code segment (as a comment) or into the above description mentioning this is Windows-only?
| "\t$SpeechSynth.Speak($CatFact.details)", | ||
| "\t$SpeechSynth = New-Object -ComObject SAPI.SpVoice", | ||
| "\t$URI = 'https://catfact.ninja/fact'", | ||
| "\t$CatFact = Invoke-WebRequest -Uri $URI | ConvertFrom-Json | Select-Object -ExpandProperty fact", |
There was a problem hiding this comment.
Suggested change
| "\t$CatFact = Invoke-WebRequest -Uri $URI | ConvertFrom-Json | Select-Object -ExpandProperty fact", | |
| "\t$CatFact = Invoke-RestMethod -Uri $URI | Select-Object -ExpandProperty fact", |
IRM does a direct JSON conversion for this purpose 🙂
There was a problem hiding this comment.
And done. Thanks 🙂
vexx32
added
Category-Advice 🗨️
vexx32
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I noticed that the 'Fun with Cat Facts' advice snippet referenced a REST API that is no longer available. I found a replacement API and made some adjustments so that the result matches the original intention.
I also noticed that the example makes use of System.Speech which works on Windows PowerShell but not PowerShell Core. I switched to the SAPI.SpVoice COM object which is also compatible with PS Core.
Context
Relates to #260
Changes
Checklist