Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ErrorOverlay component #74073

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Create ErrorOverlay component #74073

merged 4 commits into from
Dec 18, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Dec 18, 2024 •
edited
Loading

Why?

This PR refactored overlay to have a common layout as they share much in common and are also better for testing the layout. Will follow up with Errors component as it needs some UI break downs.

Note: patched @storybook/react for the type error:

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 18, 2024
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Dec 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi force-pushed the 12-18-write_story_for_the_main_dialog_and_overlay branch 2 times, most recently from 5732a8d to a218713 Compare December 18, 2024 13:54
gaojude
gaojude reviewed Dec 18, 2024
View reviewed changes
...components/react-dev-overlay/_experimental/internal/components/ErrorOverlay/ErrorOverlay.tsx Outdated
}: ErrorOverlayProps) {
const isBuildError = errorType === 'Build Error'
return (
<Overlay fixed={isBuildError}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a leaky abstraction here.

...components/react-dev-overlay/_experimental/internal/components/ErrorOverlay/ErrorOverlay.tsx Outdated Show resolved Hide resolved
@devjiwonchoi devjiwonchoi force-pushed the 12-18-write_story_for_the_main_dialog_and_overlay branch from 896e602 to a21e06b Compare December 18, 2024 17:46
@ijjk
Copy link
Member

ijjk commented Dec 18, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
buildDuration 19s 15.9s N/A
buildDurationCached 15.1s 12.8s N/A
nodeModulesSize 416 MB 416 MB ⚠️ +15.6 kB
nextStartRea..uration (ms) 470ms 476ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 233 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
index.html gzip 523 B 524 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 519 B 521 B N/A
Overall change 538 B 538 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 205 kB 205 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
middleware-b..fest.js gzip 668 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 356 kB 356 kB ⚠️ +432 B
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 137 kB 137 kB ✓
app-page.run...dev.js gzip 346 kB 347 kB ⚠️ +447 B
app-page.run..prod.js gzip 125 kB 125 kB ✓
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.5 kB 25.5 kB ✓
app-route-tu..prod.js gzip 25.3 kB 25.3 kB ✓
app-route.ru...dev.js gzip 39.1 kB 39.1 kB ✓
app-route.ru..prod.js gzip 25.3 kB 25.3 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.43 MB 2.43 MB ⚠️ +879 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 12-18-write_story_for_the_main_dialog_and_overlay Change
0.pack gzip 2.08 MB 2.08 MB ⚠️ +4.15 kB
index.pack gzip 74.4 kB 73.5 kB N/A
Overall change 2.08 MB 2.08 MB ⚠️ +4.15 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: a21e06b

@ijjk
Copy link
Member

ijjk commented Dec 18, 2024 •
edited
Loading

Tests Passed

@devjiwonchoi devjiwonchoi marked this pull request as ready for review December 18, 2024 18:02
devjiwonchoi
devjiwonchoi commented Dec 18, 2024
View reviewed changes
package.json
@@ -278,7 +278,8 @@
"scheduler": "0.25.0-rc-372ec00c-20241209"
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
"[email protected]": "patches/[email protected]",
"@storybook/[email protected]": "patches/@[email protected]"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patched @storybook/react for type error:

Opened issue at Storybook: storybookjs/storybook#30104

cc @eps1lon

This was referenced Dec 18, 2024
Merged
Merged
Open
Open
Open
@devjiwonchoi devjiwonchoi merged commit f880a7a into canary Dec 18, 2024
133 checks passed
@devjiwonchoi devjiwonchoi deleted the 12-18-write_story_for_the_main_dialog_and_overlay branch December 18, 2024 21:43
This was referenced Dec 18, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

@gaojude gaojude Awaiting requested review from gaojude

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devjiwonchoi @ijjk @huozhi @gaojude