[BREAKING] chore: Make Current BaseActivity nullable #18582

morning4coffe-dev · 2024-10-25T11:08:47Z

GitHub Issue (If applicable): closes #18573

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-10-25T11:43:23Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18582/index.html

unodevops · 2024-10-25T11:46:01Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18582/index.html

nventive-devops · 2024-10-25T13:56:52Z

The build 144894 found UI Test snapshots differences: android-28-net8: 18, android-28-net8-Snap: 42, ios: 8, ios-Snap: 50, skia-gtk-screenshots: 60, skia-linux-screenshots: 58, skia-windows-screenshots: 69, wasm: 267, wasm-automated-net9.0-UWP-Default-automated: 28, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 18 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_Buttons
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- FlyoutTest_DataBoundButton_CommandExecutes_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_ButtonInContent
- CheckBox_IsEnabled_StatePreservation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- DatePicker_PickerFlyout_PlacementstopLeft_True_False_True_UITests_Windows_UI_Xaml_Controls_DatePicker_DatePicker_Placement
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- FlyoutTest_Target_Uno_UI_Samples_Content_UITests_Flyout_Flyout_Target
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TextBox_AutoGrow_Horizontally_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Multiline_AutoHeight
- ValidateResourceLoader_Simple_UITests_Shared_Windows_ApplicationModel_Resources_ResourceLoader_ResourceLoader_Simple
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
android-28-net8-Snap: 42 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- Buttons_AppBarButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarButtonTest
- Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
- Border_Border_Simple_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple
- NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
- Buttons_AppBarToggleButtonTest_Uno_UI_Samples_Content_UITests_ButtonTestsControl_AppBarToggleButtonTest
- Transform_Image_With_RotateTransform_Uno_UI_Samples_Content_UITests_Transform_Image_With_RotateTransform
- Transform_List_With_Transformed_Ancestor_UITests_Shared_Windows_UI_Xaml_Media_Transform_List_With_Transformed_Ancestor
- Transform_Polygon_With_RotateTransform_SamplesApp_Wasm_Windows_UI_Xaml_Media_Transform_Polygon_With_RotateTransform
- Border_Border_Simple_No_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background
- WebView_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title_UITests_Windows_UI_Xaml_Controls_WebView_WebView_Title
- WebView_WebView2_JavascriptInvoke_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_JavascriptInvoke
- Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage
- Border_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
ios: 8 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
ios-Snap: 50 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- ToggleSwitch_Native_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_Native_ToggleSwitch_IsOn
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- TextBox_TextBox_BeforeTextChanging_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_BeforeTextChanging
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ListView_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled_UITests_Windows_UI_Xaml_Controls_ListView_ListViewItem_IsEnabled
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync
- Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
- Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
- Scrolling_MUXControlsTestApp_ScrollViewsWithSimpleContentsPage_MUXControlsTestApp_ScrollViewsWithSimpleContentsPage
- Windowing_UITests_Windows_UI_Xaml_WindowTests_Window_SetBackground_UITests_Windows_UI_Xaml_WindowTests_Window_SetBackground
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
- Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
skia-gtk-screenshots: 60 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- Ellipse.png
- Gamepad_CurrentReading.png-dark
- NetworkInformation.png-dark
- NetworkInformation.png
- RepeatButton_Automated.png-dark
- ContentPresenter_NativeEmbedding.png
- TextBlock_IsTextSelectionEnabled.png-dark
- TextBlock_IsTextSelectionEnabled.png
- DragDrop_TestPage.png-dark
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- UIElement_Layout_Bug2879.png-dark
- SplitButtonTestsPage.png-dark
- Examples.png
- ClipboardTests.png-dark
- ClipboardTests.png
- DragDrop_TestPage.png
- Ellipse.png-dark
skia-linux-screenshots: 58 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- Examples.png
- BorderImageBrush.png-dark
- BorderImageBrush.png
- Buttons.png-dark
- Buttons.png
- Gamepad_CurrentReading.png-dark
- ImageBrushInList.png-dark
- ImageBrushInList.png
- ClipboardTests.png-dark
- ClipboardTests.png
- ImageInStackPanel.png-dark
- ImageInStackPanel.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- BorderImageBrushRelativeTransform.png-dark
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- Gamepad_Enumeration.png-dark
- ImageIconPage.png-dark
- ImageIconPage.png
skia-windows-screenshots: 69 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- ButtonClippingTestsControl.png
- Buttons.png-dark
- Ellipse.png-dark
- Ellipse.png
- AppWindowPositionAndSize.png-dark
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- Gamepad_CurrentReading.png-dark
- ButtonClippingTestsControl.png-dark
- ClipboardTests.png-dark
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- AppWindowPositionAndSize.png
- ImageInStackPanel.png-dark
- ImageInStackPanel.png
- ImagesInlineInFlipView.png-dark
- ImagesInlineInFlipView.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- DisplayInformation.png
wasm: 267 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Samples.Shared.Content.UITests.GridViewGrouped
- initial_state
- MUXControlsTestApp.DropDownButtonPage
- SamplesApp.Windows_UI_Xaml_Controls.ContentControlNoTemplateNoContent
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathIcon
- UITests.Shared.Microsoft_UI_Xaml_Controls.RadioMenuFlyoutItemTests.RadioMenuFlyoutItemPage
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Button_UseUWPDefaultStyles
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Combined_Style
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Pressed
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Horizontal
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Vertical
- UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
- UITests.Windows_UI_Input.PointersTests.HitTest_Image
- UITests.Windows_UI_Xaml_Controls.BitmapIconTests.BitmapIcon_Sizing
- UITests.Windows_UI_Xaml_Controls.Repeater.ItemsRepeater_Basics
- nVentive.Umbrella.Views.UI.Samples.Content.UITests.ButtonTestsControl.Hyperlink_CanExecute_False
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DisplayMemberPath
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_With_ItemContainerStyle
- SamplesApp.Windows_UI_Xaml.Clipping.DoubleAnimationClipping
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_WithScrollViewer
wasm-automated-net9.0-UWP-Default-automated: 28 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Default_StrokeThickness_MyRect_0_StrokeThickness
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Default_StrokeThickness_MyLine
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrush_StreamSource
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Default_StrokeThickness_MyEllipse
- Default_StrokeThickness_MyEllipse_0_StrokeThickness
- Default_StrokeThickness_MyPath
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- Default_StrokeThickness_MyPolygon_0_StrokeThickness
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

unodevops · 2024-10-26T21:57:11Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18582/index.html

unodevops · 2024-10-26T21:59:44Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18582/index.html

nventive-devops · 2024-10-26T23:26:02Z

The build 145054 found UI Test snapshots differences: android-28-net8: 21, android-28-net8-Snap: 36, ios: 9, ios-Snap: 35, skia-gtk-screenshots: 59, skia-linux-screenshots: 50, skia-windows-screenshots: 76, wasm: 402, wasm-automated-net9.0-UWP-Default-automated: 28, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 21 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- Keyboard_Textbox_InsideScrollViewer_Validation_3_-_Remove_Focus_on_disabledTextBox
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- FocusManager_GetFocusedElement_ToggleButton_Validation_FocusManager_-_GetFocusedElement_-_ToggleButton_-_1_-_Initial_State
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- FocusManager_GetFocusedElement_ToggleButton_Validation_FocusManager_-_GetFocusedElement_-_ToggleButton_-_2_-_After_Selection
- FocusManager_GetFocusedElement_ToggleButton_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- TextBox_AutoGrow_Vertically_Wrapping_Test_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Multiline_AutoHeight
- TextBox_BeforeTextChanging_Validation_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_BeforeTextChanging
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
android-28-net8-Snap: 36 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- MUX_TwoPaneView_UITests_Shared_Microsoft_UI_Xaml_Controls_TwoPaneViewTests_TwoPaneViewPage
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- NavigationView_MUXControlsTestApp_NavigationViewTopNavPage_MUXControlsTestApp_NavigationViewTopNavPage
- TextBox_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Description_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Description
- TextBox_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Margin_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Margin
- TextBox_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_PlaceholderForeground_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_PlaceholderForeground
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- TextBlock_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_LayoutAlignment_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_LayoutAlignment
- TextBlock_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCache_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCache
- Transform_Basics_UITests_Shared_Windows_UI_Xaml_Media_Transform_Basics
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- WebView_WebView2_NavigateToUri_SamplesApp_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigateToUri
ios: 9 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- ListView_ListViewWithHeader_InitializesTest_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
ios-Snap: 35 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList_Uno_UI_Samples_UITests_ImageBrushTestControl_DoubleImageBrushInList
- Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
- TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- ListView_ListView_KeyboardInterception_UITests_Windows_UI_Xaml_Controls_ListView_ListView_KeyboardInterception
- NavigationView_MUXControlsTestApp_NavigationViewAnimationPage_MUXControlsTestApp_NavigationViewAnimationPage
- Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
- Brushes_RectangleStretchFill_Uno_UI_Samples_UITests_ImageBrushTestControl_RectangleStretchFill
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
skia-gtk-screenshots: 59 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageInStackPanel.png
- SplitButtonTestsPage.png-dark
- NetworkInformation.png-dark
- NetworkInformation.png
- TextBlock_IsTextSelectionEnabled.png-dark
- TextBlock_IsTextSelectionEnabled.png
- Gamepad_CurrentReading.png-dark
- ExpanderColorValidationPage.png-dark
- ImageIconPage.png
- ImageInStackPanel.png-dark
- RepeatButton_Automated.png-dark
- RepeatButton_Automated.png
- DropDownButtonPage.png-dark
- ClipboardTests.png-dark
- ClipboardTests.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- Buttons.png-dark
- Buttons.png
- ImageIconPage.png-dark
skia-linux-screenshots: 50 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- Gamepad_CurrentReading.png-dark
- Gamepad_CurrentReading.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ButtonClippingTestsControl.png-dark
- CalendarView_Theming.png-dark
- Focus_FocusVisual_Properties.png-dark
- Focus_FocusVisual_Properties.png
- Buttons.png-dark
- Buttons.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- Examples.png
- ImageIconPage.png-dark
- ImageIconPage.png
- ClipboardTests.png-dark
skia-windows-screenshots: 76 changed over 2222
🚨🚨 Comparison Details (first 20) 🚨🚨
- Buttons.png-dark
- Buttons.png
- ClipboardTests.png-dark
- ClipboardTests.png
- DisplayInformation.png-dark
- DisplayInformation.png
- Gamepad_CurrentReading.png-dark
- ImagesInlineInFlipView.png-dark
- ImagesInlineInFlipView.png
- CalendarView_Theming.png-dark
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- Examples.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- BorderImageBrushRelativeTransform.png-dark
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- Image_Stretch_None_ScrollViewer.png-dark
- Image_Stretch_None_ScrollViewer.png
wasm: 402 changed over 1044
🚨🚨 Comparison Details (first 20) 🚨🚨
- Benchmarks.Shared.Controls.BenchmarkDotNetTestsPage
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownWidth
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewHeaderUpdate
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewIncrementalLoading
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Expandable_Item_Large
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.PathCircularInsideEllipse
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Path_Geometry
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchNone
- UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
- UITests.Shared.Windows_UI_Xaml_Controls.GridTestsControl.Grid_Spacing_Adjustable
- UITests.Shared.Windows_UI_Xaml_Controls.ViewBoxTests.ViewBox_Alignment
- UITests.Shared.Windows_UI_Xaml_Input.Keyboard.Keyboard_Showing_Dismissal
- UITests.Windows_UI_ViewManagement.ApplicationViewSizing
- UITests.Windows_UI_ViewManagement.ApplicationViewSpanningRectsPage
- UITests.Windows_UI_ViewManagement.UISettingsTests
- UITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Dropdown_Background_4418
- UITests.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ToggleDisabled
- UITests.Windows_UI_Xaml_Controls.RelativePanelTests.RelativePanel_AlignHorizontalVerticalCenter
- UITests.Windows_UI_Xaml_Controls.RelativePanelTests.RelativePanel_MultipleCenterAlign
- UITests.Windows_UI_Xaml_Controls.ThumbTests.Thumb_DragEvents
wasm-automated-net9.0-UWP-Default-automated: 28 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Default_StrokeThickness_MyPath
- Default_StrokeThickness_MyPolyline
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Default_StrokeThickness_MyRect
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

jeromelaban · 2024-10-27T02:48:53Z

src/Uno.UI/BaseActivity.Android.cs

@@ -82,7 +82,9 @@ public static IImmutableDictionary<int, BaseActivity> Instances
 		/// For more info look at the lifecycle diagram documented here: https://developer.android.com/reference/android/app/Activity.html.
 		/// </remarks>
 		/// </summary>
-		public static BaseActivity Current => _current;
+#nullable enable
+		public static BaseActivity? Current => _current;


This will be a breaking change, we can do that, but in a future major.

chore: Make Current BaseActivity nullable

ecaf65f

github-actions bot added the platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform label Oct 25, 2024

chore: Remove empty space

96d8e8d

morning4coffe-dev marked this pull request as ready for review October 26, 2024 21:24

jeromelaban reviewed Oct 27, 2024

View reviewed changes

MartinZikmund changed the title ~~chore: Make Current BaseActivity nullable~~ [BREAKING] chore: Make Current BaseActivity nullable Oct 28, 2024

MartinZikmund marked this pull request as draft October 28, 2024 08:27

MartinZikmund added the kind/breaking-change 💥 Categorizes an issue or PR as requiring a breaking change to be fixed. label Oct 28, 2024

MartinZikmund mentioned this pull request Oct 28, 2024

[Epic] Breaking changes roundup #8339

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BREAKING] chore: Make Current BaseActivity nullable #18582

[BREAKING] chore: Make Current BaseActivity nullable #18582

morning4coffe-dev commented Oct 25, 2024

unodevops commented Oct 25, 2024

unodevops commented Oct 25, 2024

nventive-devops commented Oct 25, 2024

unodevops commented Oct 26, 2024

unodevops commented Oct 26, 2024

nventive-devops commented Oct 26, 2024

jeromelaban Oct 27, 2024

[BREAKING] chore: Make Current BaseActivity nullable #18582

Are you sure you want to change the base?

[BREAKING] chore: Make Current BaseActivity nullable #18582

Conversation

morning4coffe-dev commented Oct 25, 2024

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

unodevops commented Oct 25, 2024

unodevops commented Oct 25, 2024

nventive-devops commented Oct 25, 2024

unodevops commented Oct 26, 2024

unodevops commented Oct 26, 2024

nventive-devops commented Oct 26, 2024

jeromelaban Oct 27, 2024

Choose a reason for hiding this comment