-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to follow new architecture plus updated conditions example #6741
base: main
Are you sure you want to change the base?
Update code to follow new architecture plus updated conditions example #6741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some changes to the steps in the vite-package-setup article, and added some comments/suggestions.
Let me know what you think!
14/umbraco-cms/customizing/extending-overview/extension-types/condition.md
Outdated
Show resolved
Hide resolved
14/umbraco-cms/customizing/extending-overview/extension-types/condition.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're making some more changes to the text of the Umbraco 14 version of this article.
Should that be applied to the 15 version as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thats a mistake, these changes are for v.15 +
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! So all changes are only for 15? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
…condition.md Co-authored-by: sofietoft <[email protected]>
…condition.md Co-authored-by: sofietoft <[email protected]>
Updated code examples to follow the change of v.15.0
umbraco/Announcements#22
and as well did some corrections/updates to the Conditions example.
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?