Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure-web-apps.md umbraco load balancing settings json snippets #6610

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mattou07
Copy link
Contributor

@mattou07 mattou07 commented Oct 31, 2024

Description

What did you add/update/change?
Added code snippets for easy copy and paste of configuration in the load balancing section for web apps

If you are happy with the content, I will update all other Umbraco version markdown files. I just need to confirm the current revision is acceptable before I update all versions.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

All Umbraco Netcore 10+

Deadline (if relevant)

Not relevant

@sofietoft
Copy link
Contributor

Thanks for the PR @mattou07 !

I'll make sure we get this reviewed as soon as possible!

@sofietoft
Copy link
Contributor

Thanks again for the PR @mattou07 !

Suggestions are all great 🙌
I do have one small request though - the image!
Instead of adding through GitHub, could you upload it to the 14/umbraco-cms/fundamentals/setup/server-setup/load-balancing/images folder instead, and then add a reference to that image from the article? 🤞
We have some docs on how to work with images in the docs here: https://docs.umbraco.com/contributing/documentation/style-guide/structure#images

I hope it makes sense! Let me know if it doesn't 😄

@sofietoft
Copy link
Contributor

Hi @mattou07 ! 👋
Did you see my message about the image?

@mattou07
Copy link
Contributor Author

Hey @sofietoft

Yup I am aware of this. Just doing some juggling at work at the moment 🤹‍♂️

@sofietoft
Copy link
Contributor

Ah, no rush! 😄

@umbrabot
Copy link

umbrabot commented Dec 4, 2024

Hi there @mattou07!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

image

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants