-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add Angular 17 support & update packages #477
Merged
santoshyadavdev
merged 24 commits into
uiuniversal:master
from
Yberion:feature/476-update-angular-17
Nov 26, 2023
Merged
build: add Angular 17 support & update packages #477
santoshyadavdev
merged 24 commits into
uiuniversal:master
from
Yberion:feature/476-update-angular-17
Nov 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Nov 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments !
sheikalthaf
reviewed
Nov 23, 2023
apps/ngu-carousel-example/src/app/wrapped/wrapped-carousel/wrapped-carousel.component.html
Outdated
Show resolved
Hide resolved
There is a build error. |
Hello @santoshyadavdev, the build error seemed to be a problem on netlify's side. The new pipeline looks fine. |
Thank you @Yberion I have updated the node version it was old, I will run the pipeline again to check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @santoshyadavdev,
This PR fixes #476.
What I did:
yarn
at all this time, I switched tonpm
(even after everything was updated withnpm
and switching back toyarn
)jasmine-core
).nx
in.gitignore
ngu-carousel-example
to use the new control-flowREADME.md
ngu-carousel-example
as it was more or less uselessupdateBuildableProjectDepsInPackageJson
fromngu-carousel
as it was deprecatedtsconfig.json
(cypress) in the.eslintrc.json
ofngu-carousel
application
builder, but it was not working properly with modules.I will investigate later if it comes from(thanks @JeanMeche for his help)nx
or theAngular CLI
An interesting point to note is that if either 'ssr' or 'prerender' are set to 'true' in the configuration file, the pages served with 'ng serve' will be generated server side.
ssr-dev-server
& co.browser-esbuild
when I migrated toAngular 16
, so it is already using esbuild.ng serve
using the ssr is not usingserver.ts
(which should not affect this repo, but let's play it safe), track Providing a DI token in commonEngine.render() does not provide its value to application angular/angular-cli#26323polyfills
usageCI
setup18.13.0
, the CI now runs on['18.13.0', '20']
actions/checkout@v4
&actions/setup-node@v4
npm
ngu-carousel
forAngular 17
ngu-carousel
to9.0.0
and I updatedREADME.md
TODO on your side:
9.0.0
Tell me if everything looks ok for you.
Have a nice day.