Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zh-TW supported #332

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add zh-TW supported #332

wants to merge 4 commits into from

Conversation

ycy-0510
Copy link

📜 Description

  • add zh-TW by ZhTWFeedbackLocalizations
  • add ZhTWFeedbackLocalizations to supportedLocales
  • add locale full check in load function in l18n/translation.dart

💡 Motivation and Context

The package hasn't supported Traditional Chinese, but some people (or kids) in Asia weren't used to use Simplified Chinese. Therefore add a new language to this useful package is important and required to help people that use flutter apps with this package all over the world easily.

💚 How did you test it?

I tested them with my simple app and test/l18n/feedback_l18n_test.dart

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@ycy-0510 ycy-0510 requested a review from ueman as a code owner October 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant