Handle typing.Generic case in MRO #847
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #847 +/- ##
==========================================
- Coverage 92.79% 92.79% -0.01%
==========================================
Files 47 47
Lines 8468 8491 +23
Branches 1550 1555 +5
==========================================
+ Hits 7858 7879 +21
- Misses 350 351 +1
- Partials 260 261 +1 ☔ View full report in Codecov by Sentry. |
tristanlatr
commented
Dec 6, 2024
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This is not the most correct implementation. Sorting the MRO is not the way to go. I’ll think about it more but we might have to refactor the whole MRO computing code… |
…ould be adjustable for future tweaks like the one for typing.Generic.
…ng-Generic-in-MRO # Conflicts: # pydoctor/model.py
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Dec 9, 2024
tristanlatr
commented
Dec 9, 2024
tristanlatr
commented
Dec 9, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closed
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Dec 9, 2024
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Dec 9, 2024
tristanlatr
commented
Dec 9, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
tristanlatr
commented
Dec 12, 2024
tristanlatr
commented
Dec 12, 2024
|
Diff from pydoctor_primer, showing the effect of this PR on open source code: twisted (https://github.com/twisted/twisted)
- /projects/twisted/src/twisted/python/zippath.py:52: Cannot compute linearization of the class inheritance hierarchy
- /projects/twisted/src/twisted/python/zippath.py:261: Cannot compute linearization of the class inheritance hierarchy
|
tristanlatr
commented
Dec 13, 2024
| assert capsys.readouterr().out == '''mro:31: Cannot compute linearization of the class inheritance hierarchy of 'mro.Duplicates' | ||
| mro:9: Cannot compute linearization of the class inheritance hierarchy of 'mro.F1' | ||
| mro:10: Cannot compute linearization of the class inheritance hierarchy of 'mro.G1' | ||
| ''' |
There was a problem hiding this comment.
It would be good to have a test that ensure that a cycle in one of the base classes does not prevent to compute unrelated class’s MROS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #846.
This should also speed-up the MRO processing since we now process all classes in topological order and use caching for predecessor MROs, avoiding to re-compute for every subclasses like the current code does.