Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS breakpoint for modal. #40787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hammad-521
Copy link

@hammad-521 hammad-521 commented Sep 3, 2024

Description

Added CSS variables for modal width breakpoints and refactored the modal-test.html file to demonstrate different modal sizes.

Motivation & Context

This change allows users to set different breakpoints for different modals using CSS variables, rather than just globally with SCSS variables. It provides more flexibility in customizing modal sizes across different use cases.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@hammad-521 hammad-521 requested a review from a team as a code owner September 3, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants