Refactoring code snippets in quickstart.md #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/quickstart.md
mosabua
reviewed
Dec 5, 2024
mosabua
reviewed
Dec 5, 2024
mosabua
reviewed
Dec 5, 2024
mosabua
reviewed
Dec 5, 2024
|
@mosabua Thanks for the reivew. I've just applied your feedbacks! |
mosabua
requested changes
Dec 10, 2024
|
|
||
| for i in 1 2; do | ||
| add_backend "trino$i" "$i" | ||
| done }' |
mosabua
reviewed
Dec 10, 2024
| POSTGRES_SQL="gateway-ha-persistence-postgres.sql" | ||
| JAR_FILE="gateway-ha-$VERSION-jar-with-dependencies.jar" | ||
| GATEWAY_JAR="gateway-ha.jar" | ||
| CONFIG_YAML="quickstart-config.yaml" |
There was a problem hiding this comment.
The script doesnt actually work .. options:
- remove the log levels line in the config file
log.levels-file: .. - add a command here that adds an empty log properties file in the right folder
- add a command here that adds and empty log.properties file in the current folder and update config for current folder
There was a problem hiding this comment.
Personally I think we dont need the log levels in the quickstart .. what do you think @willmostly ?
|
Also with this whole clean up .. could we add one more config for the folder of the Trino Gateway source code .. the default could be Then the script could be used in any folder .. we would just have to document to change that variable to an absolute path to the checkout .. or even a relative one from the script directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring code snippets in quickstart.md. This PR closes #516.
Additional context and related issues
The refactoring of the script enhances readability and maintainability by organizing code into functions and adding clear comments.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.