Add monitorType JMX

[alaturqua]

Description

This pull request introduces a new monitorType for JMX-based monitoring in Trino Gateway. It includes documentation and configuration details for retrieving cluster information using specific JMX metrics.

Details

• Component: JMX Monitoring in Trino Gateway

• New Feature: Added support for monitorType: JMX to enable cluster monitoring via JMX metrics.

• Metrics Used:

  • trino.execution:name=QueryManager
  • trino.metadata:name=DiscoveryNodeManager

• Configuration Instructions:

  • Users can configure a username and password using backendState.
  • Credentials must be valid across all clusters with read rights on system_information.

• Example Configuration:

  backendState:
    username: "user"
    password: "password"
  clusterStatsConfiguration:
    monitorType: JMX

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* 

[alaturqua]

I am not very experienced with Java and Testing in Java. Please feel free to add tests.

[ebyhr]

Just skimmed.

[alaturqua]

Thanks for the reviews. I was on vacation and didn't have time to implement the requested changes yet. I will take care of them in the next days.

I might need some support to activate the /v1/jmx/mbean endpoint in the test environment for testing.

[willmostly]

@alaturqua please ping me when this is ready for another look

[alaturqua]

I had to sync my fork to be able to change my PR. But it got automatically closed, when I did so.
I am reopening.

[alaturqua]

I addressed all the points and made the changes. Tests are passing as well. Please review again.

[alaturqua]

@willmostly added documentation as well.

[willmostly]

and have read rights on the system_information.
Is there anywhere in the Trino documentation we could link to that gives an example of how to set this up? Or we could provide a snippet of FBAC configuration

[willmostly]

Add a method to create the basic auth header. I'm not sure if this is the intended use case for the HttpRequestFilter classes. Then you can just

        Request preparedRequest = prepareGet()
                .setUri(uriBuilderFrom(URI.create(jmxUrl))
                        .appendPath(JMX_PATH)
                        .appendPath(mbeanName)
                        .build())
               .addHeader("X-Trino-User", username);
        if (isHttps) {
           preparedRequest.addHeader(createBasicAuthHeader(username, password));
        }
        preparedRequest.build();

and use preparedRequest directly.

[willmostly]

queryJmx may return Optional.empty() in the case of an error response. In this case ifPresent will not trigger, and the backend stats will not be updated, so the backend will still appear healthy. You can avoid this by doing something like

Suggested change

	.ifPresent(response -> processor.process(response, clusterStats));
	.ifPresentOrElse((response -> processor.process(response, clusterStats), () -> clusterStats.trinoStatus(TrinoStatus.UNHEALTHY));

[willmostly]

create a pair of record classes for the JMX response and the attributes items, and use this instead of the generic JsonNode here and in processDiscoveryNodeManagerStats and processQueryManagerStats

[willmostly]

add tests for the failure cases, 400 and 500 response codes with non json and invalid json response bodies