-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow OAuth-SSO also when form is available #432
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Maybe we should use AuthenticationConfiguration.defaultType to decide which |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@mheers Any thoughts? |
I think it might be best to look how this is handled in Trino and then just do the same thing. |
@mheers are you still interested in working on this? |
Description
This PR allows the single-sign-on via OAuth even when formAuth is also available.
To have the API working with username/password we need to enable formAuth. When a user also configures OAuth the user could never login using this SSO because the form was prioritized.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:
* Allow OAuth-SSO also when form is available