does not rescue exceptions raised by to_x #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -702,7 +702,9 @@ def convert_type(self, w_obj, w_cls, method, raise_error=True): | |||
|
|
|||
| try: | |||
| w_res = self.send(w_obj, method) | |||
| except RubyError: | |||
| except RubyError as e: | |||
| if not isinstance(e.w_value, W_NoMethodError): | |||
There was a problem hiding this comment.
hm, to_x can raise NoMethodError by itself. may be here better check respond_to? instead of try except.
There was a problem hiding this comment.
Yes, using respond_to makes more sense if we don't want to catch that issue.
There was a problem hiding this comment.
hm, respond_to not good because of method_missing
There was a problem hiding this comment.
In my limited tests, Hash seems to swallow NoMethodErrors from insiide to_h.
There was a problem hiding this comment.
ruby -e 'x = Object.new; def x.to_int; self.aaa; end; [].take(x)'
-e:1:in `to_int': undefined method `aaa' for #<Object:0x000000026bff88> (NoMethodError)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.