Support query strings in imports #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically used in a webpack environment
jnleonard3
commented
Aug 8, 2021
| ); | ||
| }); | ||
|
|
||
| it('should resolve the file path with an extension that is non-standard in node', () => { | ||
| it('should resolve the file path while keeping the extension and query', () => { |
There was a problem hiding this comment.
This file hasn't been prettified in 2 years so I was the lucky one to make that change, but here's my first unit test asserting that a path with a query string is resolved and transformed successfully for the root path case.
jnleonard3
commented
Aug 8, 2021
| ); | ||
| }); | ||
|
|
||
| it('should alias the path with its extension and query', () => { |
There was a problem hiding this comment.
And here's the unit test when the path is aliased and has a query string
|
If anyone needs this before this becomes an official part of this project, I've published it to npm as at least my organization needs this change in the meantime: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically used in a webpack environment when using the resourceQuery loader parameter: https://webpack.js.org/configuration/module/#ruleresourcequery