Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add GitHub issue templates #6535

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Dec 13, 2024

Description

REF:#5926

Adds GitHub form isssue templates for bugs, documentation requests, and feature requests.

These files define the form structure in YAML to be rendered by GitHub in the edk2 repo issues area.

See the referenced RFC for additional details.

Future changes will add automation tasks described in the RFC. These are expected in the next couple of days or so.


Form previews:


  • Breaking change?
  • Impacts security?
  • Includes tests?

How This Was Tested

  • Verify issue template functionality on edk2 fork.

Integration Instructions

  • N/A

@makubacki makubacki self-assigned this Dec 13, 2024
@tianocore-assign-reviewers
Copy link

WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:


Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

@leiflindholm
Copy link
Member

I strongly approve of the utf-8 fixes, but they don't feel related to the PR title, nor the commit that is.

@lgao4
Copy link
Contributor

lgao4 commented Dec 16, 2024

I strongly approve of the utf-8 fixes, but they don't feel related to the PR title, nor the commit that is.

This chanage is also good to me.

@makubacki
Copy link
Member Author

I strongly approve of the utf-8 fixes, but they don't feel related to the PR title, nor the commit that is.

The files contain Unicode characters that cause the plugins to fail. I consider them a trivial tweak for this PR to pass CI. Having them in this PR ensures ordering - they go in before the templates.

To focus discussion in this PR though, I'll move them to a dedicated one. These templates will go in after the Bugzilla data has been moved to GitHub so that should provide ample time for the utf-8 PR to be completed.

@makubacki
Copy link
Member Author

Plugin PR: #6542

@leiflindholm
Copy link
Member

I strongly approve of the utf-8 fixes, but they don't feel related to the PR title, nor the commit that is.

The files contain Unicode characters that cause the plugins to fail. I consider them a trivial tweak for this PR to pass CI. Having them in this PR ensures ordering - they go in before the templates.

I'm not opposed to that workflow, but it wasn't apparent to me from the PR description or commit messages that that was why they were there.

REF:tianocore#5926

Adds GitHub form isssue templates for bugs, documentation requests,
and feature requests.

These files define the form structure in YAML to be rendered by
GitHub in the edk2 repo issues area.

See the referenced RFC for additional details.

Future changes will add automation tasks described in the RFC.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki
Copy link
Member Author

@mdkinney, I added a "code first" checkbox to each issue form.

@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Dec 20, 2024
@mergify mergify bot merged commit 40df344 into tianocore:master Dec 20, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants