fix: use happy-dom instead of jsdom in tests #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes care of the lack of reactivity seen in #119
yanick
force-pushed
the
gh119-nonbound
branch
from
c83597e to
3842014
Compare
mcous
reviewed
Jan 24, 2024
There was a problem hiding this comment.
Completely anecdotally, our main UI test suite at Viam (closed source, unfortunately) passes on jsdom and fails in lots of tests on happy-dom. I haven't dug into it yet, but it makes me a bit hesitant to switch happy-dom in the main test suite here, as promising as it is.
Something I'd like to explore is a larger matrix of test suite runs, ideally something like
- Runners: Jest, Vitest + jsdom, Vitest + happy-dom
- Svelte versions: v3, v4, v5-next
I'll file a separate ticket for that idea after I've had some time to poke at it
| test('should modify the text after clicking the button', async () => { | ||
| render(Component) | ||
| const button = screen.getByRole('button') | ||
| userEvent.click(button) |
There was a problem hiding this comment.
Shouldn't there be an await on userEvent.click, since it's an async method?
This was referenced Jan 24, 2024
|
#297 does it better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of the lack of reactivity seen in #119