chore(CI): testing releasing building on PRs #1114
Merged
+137
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriousben
force-pushed
the
seriousben/fix-cross-builds
branch
6 times, most recently
from
65a45ec to
a59f6e9
Compare
seriousben
force-pushed
the
seriousben/fix-cross-builds
branch
2 times, most recently
from
63d633f to
bcc854c
Compare
seriousben
force-pushed
the
seriousben/fix-cross-builds
branch
from
bcc854c to
408ef7c
Compare
eabatalov
reviewed
Dec 18, 2024
| "dpkg --add-architecture $CROSS_DEB_ARCH", | ||
| "mkdir -p /.npm", | ||
| "chown -R 1000:1000 /.npm" | ||
| "chown -R 1001:128 /.npm" |
There was a problem hiding this comment.
Looks like some pure magic. Is this Ubuntu specific uid, gid?
There was a problem hiding this comment.
Something like that. For some reason this started breaking for Ubuntu 20 and 22.
That is the part, I can't explain.
|
Very nice cleanup + ubuntu update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Issues preventing publishing of the server are only found at publishing time.
What
This PR builds the release packages on PRs to detect issues early and aligns x86 with arm64.
It is possible to remove our docker images, cross still defaults to ubuntu 20.04 and there are some node 22 dependency conflicts when using ubuntu 20.04 with what is installed by cross.
See cross-rs/cross#1580 and cross-rs/cross#973
In the future, we should also build images on PR, but since our release image relies on deb, this is impractical for this PR.
Testing
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.