Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase line coverage for Temporal #4329

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Increase line coverage for Temporal #4329

wants to merge 8 commits into from

Conversation

anba
Copy link
Contributor

@anba anba commented Nov 19, 2024

Add tests to increase line coverage. Whenever possible, I've tried to copy the code style from other Temporal tests.

Steps performed:

  • Compile SpiderMonkey with code coverage enabled.
  • Run tests for a single class, e.g. built-ins/Temporal/ZonedDateTime/.
  • Create grcov report to find missing coverage.
  • Add tests for the missing coverage.
  • Repeat step 2 with the next directory.

This PR doesn't address all missing coverage, for example Temporal.Duration still has some lines which aren't covered. I've also didn't yet run any tests under intl402/Temporal.

@anba anba requested a review from a team as a code owner November 19, 2024 15:47
ptomato
ptomato requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough work! I do have questions or disagreements with a few of these tests, but the vast majority look great.

test/built-ins/Temporal/Duration/from/argument-string-is-infinity.js Outdated Show resolved Hide resolved
test/built-ins/Temporal/Duration/prototype/total/relativeto-plaindatetime.js Outdated Show resolved Hide resolved
test/built-ins/Temporal/PlainDateTime/prototype/subtract/throws-if-duration-days-too-large.js Outdated Show resolved Hide resolved
test/built-ins/Temporal/PlainMonthDay/prototype/toLocaleString/return-string.js Outdated Show resolved Hide resolved
test/built-ins/Temporal/PlainYearMonth/prototype/toLocaleString/return-string.js Outdated Show resolved Hide resolved
harness/temporalHelpers.js Outdated Show resolved Hide resolved
@anba anba force-pushed the temporal-coverage branch from 9c01216 to bd07fd0 Compare December 12, 2024 17:01
@anba
Copy link
Contributor Author

anba commented Dec 12, 2024

Addressed all review comments.

@anba anba force-pushed the temporal-coverage branch from bd07fd0 to 94cf340 Compare December 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anba @ptomato