d8: Remove experimental notice from stderr #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you invoke d8 with any --harmony flags, it prints a warning to stderr that you are using experimental technologies. Remove this warning from the captured stderr, because it's just noise - if you are running d8 with a --harmony flag via eshost, you probably know what you are doing. Additionally, non-empty stderr makes test262harness think the test has failed, so it's currently impossible to run test262 tests for a --harmony feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you invoke
d8with any--harmonyflags, it prints a warning to stderr that you are using experimental technologies. Remove this warning from the captured stderr, because it's just noise - if you are runningd8with a--harmonyflag viaeshost, you probably know what you are doing.Additionally, non-empty stderr makes test262harness think the test has failed, so it's currently impossible to run test262 tests for a
--harmonyfeature.