Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html to make the text below navbar visible #577

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Srishti-Chugh
Copy link

This PR adjusts the spacing to prevent the text below navbar from being hidden.
The issue #574 was identified on the homepage, where the "Sugar Labs" heading was obscured by the navbar. I've added some spacing to ensure proper visibility.

Changes made:
Increased top margin for the "Sugar Labs" heading to create space between it and the navbar.
Ensured the page remains responsive across various screen sizes.

Screenshots:
Before
old sugarlabs title page
After adding margin
new sugarlabs title page

Please review this and let me know if any further changes are needed.

@quozl
Copy link
Contributor

quozl commented Dec 7, 2024

  • your commit message does not follow our making commits guidance,
  • don't say "Update index.html" because it is obvious from the rest of the commit which files you have changed.

@pikurasa
Copy link
Contributor

@Srishti-Chugh I think this is good, but can you make a new PR with James's suggestions?

Part of this is learning best practices, so I think it's worth doing once more, following the guidance.

@pikurasa
Copy link
Contributor

@Srishti-Chugh Will you be working to address James's comments? Please let us know either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants