-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating dialogue box for the move to trash button #4081
base: master
Are you sure you want to change the base?
Conversation
Adding confirmation for the move to trash button
in order for the dialogue box to appear on the top level
This looks very nice. Not 100% sure it is necessary, since there is a restore from trash mechanism. I think the confirmation dialog should be required for irreversible actions, such as starting a new project and clearing the screen. @pikurasa What do you think? |
@walterbender so i think i must create this dialogue box for the new project and clear button so this will be a nice enhancement |
@walterbender should i close this pr or modify it only in order to make the changes for the new project dialogue box |
let's wait to see what devin says |
It does look nice.
|
I like Devin's idea. |
Yaaa I too like the concept well @pikurasa what do you mean by the notification it's the music blocks notification block or the one which I make like dialogue box with a simple close button in it what's your view too @walterbender |
Just the msgText mechanism is what I think he means. (or is textMsg)? |
@walterbender yaa I do think so as the notification or error is displayed in MB |
a notification. it is not an error. |
@walterbender yaaa I ll create a notification block for the move to trash button can you tell me the dialogue it must display.. |
"You can restore deleted objects from the trash with the Restore From Trash button." @pikurasa OK? |
I think that's fine. |
Maybe ^objects^blocks |
Kids won't know what "objects" are, but they know what blocks are. |
Two things:
|
@pikurasa can you clarify more so the requested changes I will do |
I think moving the blocks to trash with drag and drop does not results in a notification currently. Creating a MR for that |
When you have a chance, please resolve the conflicts. |
#4079 New enhancement is done for the move to trash button in the block context piemenu as now when the person tries to put the block in the trash ther appears a dialogue block with displaying two button confirm and cancel
Screen.Recording.2024-11-25.at.2.30.07.PM.mov