Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating dialogue box for the move to trash button #4081

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omsuneri
Copy link
Contributor

@omsuneri omsuneri commented Nov 25, 2024

#4079 New enhancement is done for the move to trash button in the block context piemenu as now when the person tries to put the block in the trash ther appears a dialogue block with displaying two button confirm and cancel

Screen.Recording.2024-11-25.at.2.30.07.PM.mov

Adding confirmation for the move to trash button
in order for the dialogue box to appear on the top level
@omsuneri omsuneri changed the title Fixes Issue #4079 refactor confirm button on clear creating dialogue box for the move to trash button Nov 25, 2024
@walterbender
Copy link
Member

This looks very nice. Not 100% sure it is necessary, since there is a restore from trash mechanism. I think the confirmation dialog should be required for irreversible actions, such as starting a new project and clearing the screen. @pikurasa What do you think?

@omsuneri
Copy link
Contributor Author

@walterbender so i think i must create this dialogue box for the new project and clear button so this will be a nice enhancement

@omsuneri
Copy link
Contributor Author

@walterbender should i close this pr or modify it only in order to make the changes for the new project dialogue box

@walterbender
Copy link
Member

let's wait to see what devin says

@pikurasa
Copy link
Collaborator

It does look nice.

  1. I agree that we can use it for the irreversible actions new project and clearing the screen
  2. As for trash, perhaps we can have a notification that pops up to tell the user that they have the restore option -- thoughts?

@walterbender
Copy link
Member

I like Devin's idea.

@omsuneri
Copy link
Contributor Author

Yaaa I too like the concept well @pikurasa what do you mean by the notification it's the music blocks notification block or the one which I make like dialogue box with a simple close button in it what's your view too @walterbender

@walterbender
Copy link
Member

walterbender commented Nov 25, 2024

Just the msgText mechanism is what I think he means. (or is textMsg)?

@omsuneri
Copy link
Contributor Author

@walterbender yaa I do think so as the notification or error is displayed in MB

@walterbender
Copy link
Member

a notification. it is not an error.

@omsuneri
Copy link
Contributor Author

@walterbender yaaa I ll create a notification block for the move to trash button can you tell me the dialogue it must display..

@walterbender
Copy link
Member

"You can restore deleted objects from the trash with the Restore From Trash button." @pikurasa OK?

@pikurasa
Copy link
Collaborator

"You can restore deleted objects from the trash with the Restore From Trash button." @pikurasa OK?

I think that's fine.

@walterbender
Copy link
Member

Maybe ^objects^blocks

@walterbender
Copy link
Member

Kids won't know what "objects" are, but they know what blocks are.

@pikurasa
Copy link
Collaborator

pikurasa commented Dec 5, 2024

Two things:

  • I think Issue #4094: Add Optional Timeout to Message Dismissal #4097 picked up the message that this PR was suppose to introduce
  • I tried master just now, and, while the message does pop-up when you trash something from right-click menu, the message does not display when trashing from dragging to lower-right trash.

@omsuneri
Copy link
Contributor Author

omsuneri commented Dec 5, 2024

@pikurasa can you clarify more so the requested changes I will do

@BeNikk
Copy link
Contributor

BeNikk commented Dec 6, 2024

I think moving the blocks to trash with drag and drop does not results in a notification currently. Creating a MR for that

@walterbender
Copy link
Member

When you have a chance, please resolve the conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants