Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt CLI installation in modal #191

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Conversation

vcheung-stripe
Copy link
Collaborator

@vcheung-stripe vcheung-stripe commented Mar 16, 2021

Show a more prominent message to install the CLI. Deep-link to https://stripe.com/docs/stripe-cli#install. Rename some variables for clarity.

Before:
Screen Shot 2021-03-15 at 5 06 01 PM

After:
Screen Shot 2021-03-12 at 3 05 38 PM

Part of #187.

Updated existing test and manually verified.

Copy link
Contributor

@gracegoo-stripe gracegoo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vcheung-stripe vcheung-stripe merged commit 1296a65 into master Mar 16, 2021
@vcheung-stripe vcheung-stripe deleted the vcheung/cli-ux-improvements branch March 16, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants