fix: fixes an issue where the next-font plugin would not work on windows #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
requested changes
Nov 4, 2024
| src: url(${localFontSrc.fontReferenceId ? getPlaceholderFontUrl(localFontSrc.fontReferenceId) : `/@fs${localFontSrc.fontPath}`}) | ||
| src: url(${localFontSrc.fontReferenceId ? getPlaceholderFontUrl(localFontSrc.fontReferenceId) : `${localFontSrc.fontPath}`}) |
There was a problem hiding this comment.
Unfortunately, this breaks local fonts in Vitest.
Reproduction:
- Go to
example/.storybook/vitest.config.mtsand setheadless: true(line 25) - Run
pnpm run dev - Go to
exampleand runpnpm run test:allin a separate terminal window - Got to Vitest inspector (http://localhost:5173/), wait for the test result to finish, and rerun the Font.stories.ts tests.
You can observe, that the local fonts are not correctly rendered.
|
Hey @GeeWizWow! As a fellow Windows user, I've had a similar problem in the Might I suggest applying this same fix there too (as well as any other appropriate places in this package)? 🙂 Happy to make the changes myself in another PR if needed, but it might make sense to change them all together for a consistent experience. |
|
Hey Ryan, I’ve not got the time or headspace to follow up on this, so I’d
suggest you tackle them in a new PR, and I’ll close this when I’m next at a
PC.
But let me know if there’s anything I can do to help.
Cheers!
…On Fri, 13 Dec 2024 at 14:32, Ryan Butt ***@***.***> wrote:
Hey @GeeWizWow <https://github.com/GeeWizWow>! As a fellow Windows user,
I've had a similar problem in the next-image plugin here:
https://github.com/storybookjs/vite-plugin-storybook-nextjs/blob/819cdd357577625ccc201a9669fccc38888e98d2/src/plugins/next-image/plugin.ts#L70,
which results in our Storybook build failing on Windows devices.
Might I suggest applying this same fix there too (as well as any other
appropriate places in this package)? 🙂
Happy to make the changes myself in another PR if needed, but it might
make sense to change them all together for a consistent experience.
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEVDETFUT2IBIT2M7IMX332FLVXPAVCNFSM6AAAAABOHCHPB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBRGU4DQNJWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
No worries! I'll try to find the time to get something done soon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
path.posix.sepinstead of the platform specific one. This matches vite's behavior of using unix path separators regardless of the platform.Additionally had to convert the final fontPath from windows separators to unix ones, as well as remove the use of an absolute path. the absolute path especially presented a number of issues with character escaping that I wasn't able to track down.