fix: Handling of rawSourceMap string type in webpack5-istanbul-loader #44
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added typeof string check so that a raw source map string gets parsed into an object.
gpincheiraa
approved these changes
Dec 18, 2024
|
Please merge this Pull Request!!! |
|
Using this fix works like a charm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
I noticed a regression in the latest version v1.0.4. The same issue was previously reported here #32, and fixed in #33. However, it was reintroduced as part of Fix sourcemap generation for Webpack5 projects.
I hope you are okay to merge this patch and cut a bugfix release when you get a chance, please.
Thank you kindly,
Mike